diff options
author | Louis Yung-Chieh Lo <yjlou@chromium.org> | 2012-03-28 16:51:40 +0800 |
---|---|---|
committer | Louis Yung-Chieh Lo <yjlou@chromium.org> | 2012-03-28 16:51:40 +0800 |
commit | 8d6725baf34a5c900021d9c4e336eeba98df05f1 (patch) | |
tree | 37471f81550200a00087b8b488424b6e5d26039f | |
parent | b71837716d1c049df622077de397ea77bfa85147 (diff) | |
download | chrome-ec-8d6725baf34a5c900021d9c4e336eeba98df05f1.tar.gz |
Remove the un-necessary TODO comments in i8042 module.
See issue tracker for more information.
BUG=chrome-os-partner:8493
TEST=compile okay
Change-Id: I910aebec7d2a505a02b1bbd5d985a540b94be5c2
-rw-r--r-- | common/i8042.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/common/i8042.c b/common/i8042.c index da4f7ea2ac..7bf7a55de9 100644 --- a/common/i8042.c +++ b/common/i8042.c @@ -71,7 +71,7 @@ static void enq_to_host(int len, uint8_t *to_host) { int from, to; - /* TODO: need atomic protection */ + /* Check if the buffer has enough space, then copy them to buffer. */ if ((tail_to_buffer + len) <= (head_to_buffer + HOST_BUFFER_SIZE - 1)) { for (from = 0, to = tail_to_buffer; from < len;) { to_host_buffer[to++] = to_host[from++]; @@ -79,7 +79,6 @@ static void enq_to_host(int len, uint8_t *to_host) } tail_to_buffer = (tail_to_buffer + len) % HOST_BUFFER_SIZE; } - /* end of atomic protection */ } @@ -105,11 +104,10 @@ void i8042_command_task(void) uint8_t chr; int empty = 0; - /* TODO: need atomic protection */ + /* Check if we have data in buffer to host. */ if (head_to_buffer == tail_to_buffer) { empty = 1; /* nothing to host */ } - /* end of atomic protection */ if (empty) break; /* if the host still didn't read that away, @@ -124,11 +122,10 @@ void i8042_command_task(void) break; } - /* TODO: need atomic protection */ + /* Get a char from buffer. */ chr = to_host_buffer[head_to_buffer]; head_to_buffer = (head_to_buffer + 1) % HOST_BUFFER_SIZE; - /* end of atomic protection */ /* Write to host. */ keyboard_put_char(chr, i8042_irq_enabled); |