diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-08-13 15:45:30 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-08-14 22:42:36 +0000 |
| commit | 521dd8a8c79e18e5b54069766eb68ed32c54a0ce (patch) | |
| tree | 638b12b09d4aa989638d284c4409049cba96a806 | |
| parent | 87f2f10b8e3b49bd8d23be262a677d0685b5adfe (diff) | |
| download | chrome-ec-521dd8a8c79e18e5b54069766eb68ed32c54a0ce.tar.gz | |
pd: Fix bug in PD console command
The check on number of arguments is offset by 1. Fix it.
BUG=None
TEST=Run the commands with one parameter short. See error.
BRANCH=None
Change-Id: I2ac1fe022d22bbef2ee90fe54a7856766fc31dcc
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/212352
Reviewed-by: Alec Berg <alecaberg@chromium.org>
| -rw-r--r-- | common/usb_pd_protocol.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/common/usb_pd_protocol.c b/common/usb_pd_protocol.c index 154c338d1d..bf77755941 100644 --- a/common/usb_pd_protocol.c +++ b/common/usb_pd_protocol.c @@ -1493,14 +1493,14 @@ static int command_pd(int argc, char **argv) task_wake(PORT_TO_TASK_ID(port)); } else if (!strncasecmp(argv[2], "dev", 3)) { int max_volt = -1; - if (argc >= 3) + if (argc >= 4) max_volt = strtoi(argv[3], &e, 10) * 1000; pd_request_source_voltage(port, max_volt); } else if (!strcasecmp(argv[2], "clock")) { int freq; - if (argc < 3) + if (argc < 4) return EC_ERROR_PARAM2; freq = strtoi(argv[3], &e, 10); @@ -1521,7 +1521,7 @@ static int command_pd(int argc, char **argv) } else if (!strcasecmp(argv[2], "enable")) { int enable; - if (argc < 3) + if (argc < 4) return EC_ERROR_PARAM_COUNT; enable = strtoi(argv[3], &e, 10); |