summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAseda Aboagye <aaboagye@google.com>2015-06-25 09:36:10 -0700
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2015-06-30 17:18:45 +0000
commit9e73f3e0318c992d7cf50164edb0645c2d363205 (patch)
tree99b8265f44f0888ce2fd24b7e4348f2be6632464
parent4a56579f21e5aced3673d694fc45811cfd439d84 (diff)
downloadchrome-ec-9e73f3e0318c992d7cf50164edb0645c2d363205.tar.gz
presubmit: Add hook to check for config options.
This enables a presubmit hook to check for missing configuration options. All CONFIG_* options should be defined in include/config.h along with a brief description of what the config option does. BUG=chrome-os-partner:26304 BRANCH=none CQ-DEPEND=CL:281626 TEST=Create a commit modifying a source file with a new CONFIG_* option and watched the preupload process fail illustrating the error with the CONFIG_* option. TEST=make -j buildall tests Change-Id: I7240b386b4981dcab66811a4829d7d6ebfbf7cb1 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/281826 Reviewed-by: Randall Spangler <rspangler@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
-rw-r--r--PRESUBMIT.cfg1
1 files changed, 1 insertions, 0 deletions
diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
index a4d1071940..bf39804563 100644
--- a/PRESUBMIT.cfg
+++ b/PRESUBMIT.cfg
@@ -11,3 +11,4 @@ checkpatch_check: --no-tree --ignore=MSLEEP,VOLATILE
[Hook Scripts]
hook0 = util/presubmit_check.sh 2>&1
+hook1 = util/config_option_check.py 2>&1 \ No newline at end of file