diff options
| author | Dino Li <dino.li@ite.com.tw> | 2016-02-17 13:31:30 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-02-17 20:57:01 -0800 |
| commit | 5a7767a20e3f654298eb1f92ace1e9d0d8a332c8 (patch) | |
| tree | 1c39002374fa9c74e07cd87725253c3b9d5c2a1c | |
| parent | c505edb0b5f3ed329338047127f356733ab72184 (diff) | |
| download | chrome-ec-5a7767a20e3f654298eb1f92ace1e9d0d8a332c8.tar.gz | |
config: it83xx: remove "CONFIG_IT83XX_PECI_WITH_INTERRUPT"
IT839x and the new series all support interrupt of PECI, so we remove it.
Signed-off-by: Dino Li <dino.li@ite.com.tw>
BRANCH=none
BUG=none
TEST=make -j buildall
Change-Id: Ib126cb418a4ba5ef313ee93948bc2fbb96bc936d
Reviewed-on: https://chromium-review.googlesource.com/327643
Commit-Ready: Dino Li <dino.li@ite.com.tw>
Tested-by: Dino Li <dino.li@ite.com.tw>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/it8380dev/board.h | 1 | ||||
| -rw-r--r-- | chip/it83xx/peci.c | 11 | ||||
| -rw-r--r-- | include/config.h | 3 |
3 files changed, 0 insertions, 15 deletions
diff --git a/board/it8380dev/board.h b/board/it8380dev/board.h index c9597a8af0..624fbd1772 100644 --- a/board/it8380dev/board.h +++ b/board/it8380dev/board.h @@ -18,7 +18,6 @@ #define CONFIG_I2C_MASTER #define CONFIG_IT83XX_KEYBOARD_KSI_WUC_INT #define CONFIG_IT83XX_LPC_ACCESS_INT -#define CONFIG_IT83XX_PECI_WITH_INTERRUPT #define CONFIG_IT83XX_SMCLK2_ON_GPC7 #define CONFIG_KEYBOARD_BOARD_CONFIG #define CONFIG_KEYBOARD_PROTOCOL_8042 diff --git a/chip/it83xx/peci.c b/chip/it83xx/peci.c index 7aa1dbb0e8..7682ddbcfe 100644 --- a/chip/it83xx/peci.c +++ b/chip/it83xx/peci.c @@ -185,7 +185,6 @@ static enum peci_status peci_transaction(uint8_t addr, IT83XX_PECI_HOWRDR = w_buf[index]; peci_current_task = task_get_current(); -#ifdef CONFIG_IT83XX_PECI_WITH_INTERRUPT task_clear_pending_irq(IT83XX_IRQ_PECI); task_enable_irq(IT83XX_IRQ_PECI); @@ -198,17 +197,7 @@ static enum peci_status peci_transaction(uint8_t addr, index = 0; task_disable_irq(IT83XX_IRQ_PECI); -#else - /* start */ - IT83XX_PECI_HOCTLR |= 0x01; - - for (index = 0x00; index < timeout_us; index += 16) { - if (IT83XX_PECI_HOSTAR & PECI_STATUS_ANY_BIT) - break; - udelay(15); - } -#endif peci_current_task = TASK_ID_INVALID; if (index < timeout_us) { diff --git a/include/config.h b/include/config.h index 303826a76a..93597f241f 100644 --- a/include/config.h +++ b/include/config.h @@ -1176,9 +1176,6 @@ /* LPC cycle can wake-up EC from doze / deep doze mode if define it. */ #undef CONFIG_IT83XX_LPC_ACCESS_INT -/* Interrupt for PECI module. (IT839X series and IT838X DX only) */ -#undef CONFIG_IT83XX_PECI_WITH_INTERRUPT - /* To define it, if I2C channel C and PECI used at the same time. */ #undef CONFIG_IT83XX_SMCLK2_ON_GPC7 |