cr50: drop obsolete/addressed TODOs

There many TODOs sprinkled in the code, some of them have been
addressed or do not apply any mode. This patch removes them.

BRANCH=cr50
BUG=none
TEST=built and ran cr50 on reef

Change-Id: Ica6edb204e5cc0cc9dc7f0d43fd39e7ddaf56809
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/506496
Reviewed-by: Randall Spangler <rspangler@chromium.org>

7 files changed, 0 insertions, 33 deletions

diff --git a/board/cr50/board.h b/board/cr50/board.h
index 601f9a7423..70e7a6f7ba 100644
--- a/board/cr50/board.h
+++ b/board/cr50/board.h
@@ -38,9 +38,7 @@
 
 /* Flash configuration */
 #undef CONFIG_FLASH_PSTATE
-/* TODO(crosbug.com/p/44745): Bringup only! Do the right thing for real! */
 #define CONFIG_WP_ALWAYS
-/* TODO(crosbug.com/p/44745): For debugging only */
 #define CONFIG_CMD_FLASH
 
 /* We're using TOP_A for partition 0, TOP_B for partition 1 */
@@ -213,9 +211,6 @@ int board_tpm_uses_spi(void);
 
 #define UARTN UART_CR50
 
-/* TODO(crosbug.com/p/56540): Remove this when UART0_RX works everywhere */
-#define GC_UART0_RX_DISABLE
-
 #define CC_DEFAULT     (CC_ALL & ~CC_MASK(CC_TPM))
 
 /* Nv Memory users */
@@ -228,13 +223,6 @@ enum nvmem_users {
 #endif
 
 #define CONFIG_FLASH_NVMEM_VARS_USER_NUM NVMEM_CR50
-
-/*
- * Let's be on the lookout for stack overflow, while debugging.
- *
- * TODO(vbendeb): remove this before finalizing the code.
- */
-#define CONFIG_DEBUG_STACK_OVERFLOW
 #define CONFIG_RW_B
 
 /* Firmware upgrade options. */
diff --git a/board/cr50/tpm2/stubs.c b/board/cr50/tpm2/stubs.c
index d3e8710604..2d38b2c904 100644
--- a/board/cr50/tpm2/stubs.c
+++ b/board/cr50/tpm2/stubs.c
@@ -52,7 +52,6 @@ BOOL _cpri__Startup(
   /*
    * Below is the list of functions called by the TPM2 library from
    * _cpri__Startup().
-   * TODO(vbendeb): verify proper initialization.
    *
    *  _cpri__HashStartup() - not doing anything for now, maybe hw
    *               reinitialization is required?
diff --git a/board/cr50/wp.c b/board/cr50/wp.c
index 63ca909c9b..84ca26d1a0 100644
--- a/board/cr50/wp.c
+++ b/board/cr50/wp.c
@@ -436,13 +436,6 @@ static int command_lock(int argc, char **argv)
 			goto out;
 		}
 
-		/*
-		 * TODO(crosbug.com/p/55322, crosbug.com/p/55728): There may be
-		 * other preconditions which must be satisified before
-		 * continuing. We can return EC_ERROR_ACCESS_DENIED if those
-		 * aren't met.
-		 */
-
 		/* Don't count down if we know it's likely to fail */
 		if (unlock_in_progress) {
 			ccprintf("An unlock process is already in progress\n");
diff --git a/chip/g/idle.c b/chip/g/idle.c
index 3544948b5f..a3501973de 100644
--- a/chip/g/idle.c
+++ b/chip/g/idle.c
@@ -107,9 +107,6 @@ static void prepare_to_sleep(void)
 	/*
 	 * Deep sleep should only be enabled when the AP is off otherwise the
 	 * TPM state will lost.
-	 *
-	 * TODO(crosbug.com/p/55747): Enable deep sleep when the AP is shut
-	 * down. Currently deep sleep is only enabled through the console.
 	 */
 	if (idle_action == IDLE_DEEP_SLEEP) {
 		/* Clear upcoming events. They don't matter in deep sleep */
diff --git a/chip/g/pmu.c b/chip/g/pmu.c
index f6ec4d164d..47b8341d5a 100644
--- a/chip/g/pmu.c
+++ b/chip/g/pmu.c
@@ -7,11 +7,6 @@
 #include "task.h"
 
 /*
- * TODO_FPGA this file should be thoroughly reworked when actual support is
- * introduced.
- */
-
-/*
  * RC Trim constants
  */
 #define RCTRIM_RESOLUTION       (12)
diff --git a/chip/g/system.c b/chip/g/system.c
index dea76c082f..9fa5385907 100644
--- a/chip/g/system.c
+++ b/chip/g/system.c
@@ -88,9 +88,6 @@ void system_pre_init(void)
 
 void system_reset(int flags)
 {
-	/* TODO: Do we need to handle SYSTEM_RESET_PRESERVE_FLAGS? Doubtful. */
-	/* TODO(crosbug.com/p/47289): handle RESET_FLAG_WATCHDOG */
-
 	/* Disable interrupts to avoid task swaps during reboot */
 	interrupt_disable();
 
@@ -230,7 +227,6 @@ int system_battery_cutoff_support_required(void)
 	return 0;
 }
 
-/* TODO(crosbug.com/p/33822): Where can we store stuff persistently? */
 int system_get_bbram(enum system_bbram_idx idx, uint8_t *value)
 {
 	return 0;
diff --git a/chip/g/upgrade_fw.h b/chip/g/upgrade_fw.h
index 092f2812fa..0ea3314427 100644
--- a/chip/g/upgrade_fw.h
+++ b/chip/g/upgrade_fw.h
@@ -112,7 +112,6 @@ struct first_response_pdu {
 	uint32_t keyid[2];
 };
 
-/* TODO: Handle this in upgrade_fw.c, not usb_upgrade.c */
 #define UPGRADE_DONE          0xB007AB1E
 
 void fw_upgrade_command_handler(void *body,