diff options
| author | Nicolas Norvez <norvez@chromium.org> | 2018-10-05 21:27:54 +0000 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-10-05 21:43:23 +0000 |
| commit | 9e892d737c9357a75b8ed80e60ed9a33574cd124 (patch) | |
| tree | 684ad3220432834280bbb3b326e86ca583f87db0 | |
| parent | 23de40774b7c86ec932ac6001d7c4b257fddd0d4 (diff) | |
| download | chrome-ec-9e892d737c9357a75b8ed80e60ed9a33574cd124.tar.gz | |
Revert "fpsensor: FP_INFO reports the template version"
This reverts commit 23de40774b7c86ec932ac6001d7c4b257fddd0d4.
Reason for revert: Broke chromeos-ec compilation
Original change's description:
> fpsensor: FP_INFO reports the template version
>
> Add a field to the ec_response_fp_info structure to report the version
> of the template format supported by the hardware.
> We'd normally uprev the structure version, but given there are only 2
> clients of that API (ectool and biod), we'll rather synchronise the
> submission of the CLs to avoid unnecessary complexity.
>
> BRANCH=nocturne
> BUG=b:116979455
> TEST=ectool --name=cros_fp fpinfo
> TEST=start biod, log shows the format version
>
> Change-Id: Ibbf2a3603d4f28c7550523f785aeb7fb740ac9ea
> Signed-off-by: Nicolas Norvez <norvez@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/1252459
> Reviewed-by: Prashant Malani <pmalani@chromium.org>
> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> (cherry picked from commit f7882a11b335dd67597bc0cb230acf1f0a81cd67)
> Reviewed-on: https://chromium-review.googlesource.com/c/1265056
Bug: b:116979455
Change-Id: Idd8a3838b139fe12511f8fee1e3ac55c052fc989
Reviewed-on: https://chromium-review.googlesource.com/c/1265738
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Commit-Queue: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
| -rw-r--r-- | common/fpsensor.c | 1 | ||||
| -rw-r--r-- | include/ec_commands.h | 1 | ||||
| -rw-r--r-- | util/ectool.c | 7 |
3 files changed, 3 insertions, 6 deletions
diff --git a/common/fpsensor.c b/common/fpsensor.c index 26ab78bda0..f41f8013bd 100644 --- a/common/fpsensor.c +++ b/common/fpsensor.c @@ -396,7 +396,6 @@ static int fp_command_info(struct host_cmd_handler_args *args) r->template_max = FP_MAX_FINGER_COUNT; r->template_valid = templ_valid; r->template_dirty = templ_dirty; - r->template_version = FP_TEMPLATE_FORMAT_VERSION; /* V1 is identical to V0 with more information appended */ args->response_size = args->version ? sizeof(*r) : diff --git a/include/ec_commands.h b/include/ec_commands.h index 54c7827231..e45e56911c 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -5022,7 +5022,6 @@ struct __ec_align4 ec_response_fp_info { uint16_t template_max; /* maximum number of fingers/templates */ uint16_t template_valid; /* number of valid fingers/templates */ uint32_t template_dirty; /* bitmap of templates with MCU side changes */ - uint32_t template_version; /* version of the template format */ }; /* Get the last captured finger frame or a template content */ diff --git a/util/ectool.c b/util/ectool.c index dbb995e10a..c2ce4dc8da 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -1503,10 +1503,9 @@ int cmd_fp_info(int argc, char *argv[]) } if (cmdver == 1) { - printf("Templates: version %d size %d count %d/%d" - " dirty bitmap %x\n", - r.template_version, r.template_size, r.template_valid, - r.template_max, r.template_dirty); + printf("Templates: size %d count %d/%d dirty bitmap %x\n", + r.template_size, r.template_valid, r.template_max, + r.template_dirty); } return 0; |