diff options
| author | michael_chen <michael5_chen@pegatroncorp.com> | 2018-10-09 12:58:44 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-09 05:10:46 -0700 |
| commit | fa06e1f393c1a9c644b8731b8fde17af10dd9907 (patch) | |
| tree | 0afc6af18a12769a519180a0709387d4a3864443 | |
| parent | d5a657ab1d77dce1e54d283b3556acf940d10426 (diff) | |
| download | chrome-ec-fa06e1f393c1a9c644b8731b8fde17af10dd9907.tar.gz | |
rammus: Fix power leakage
Modify PMIC and GPIO setting to fix power leakage.
Dependent on EE request:
1. Init PMIC Discharge control register.
1.1. Discharge control register 1 (0x3C) = 0x00.
1.2. Discharge control register 2 (0x3D) = 0x55.
1.3. Discharge control register 3 (0x3E) = 0x44.
1.4. Discharge control register 4 (0x3F) = 0x04.
2. Remove gpio "TP_INT_CONN" GPIO_PULL_UP configuration.
BUG=b:117194355
BRANCH=ToT
TEST=Manual
EE measure power and check it is improve.
Change-Id: I8b0e5ff479fee0ebcc26e9e57073ec6b5fc8868f
Signed-off-by: michael_chen <michael5_chen@pegatroncorp.com>
Reviewed-on: https://chromium-review.googlesource.com/1253369
Commit-Ready: michael chen <michael5_chen@pegatroncorp.com>
Tested-by: michael chen <michael5_chen@pegatroncorp.com>
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
| -rw-r--r-- | board/rammus/board.c | 11 | ||||
| -rw-r--r-- | board/rammus/gpio.inc | 2 |
2 files changed, 10 insertions, 3 deletions
diff --git a/board/rammus/board.c b/board/rammus/board.c index 365ab60bc6..2f88f6c293 100644 --- a/board/rammus/board.c +++ b/board/rammus/board.c @@ -407,8 +407,15 @@ static void board_pmic_init(void) if (system_jumped_to_this_image()) return; - /* DISCHGCNT3 - enable 100 ohm discharge on V1.00A */ - i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x3e, 0x04); + /* + * DISCHGCNT2 - enable 100 ohm discharge on + * V5A_DS3/V33A_DSW/V33A_PCH/V1.8A + */ + i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x3d, 0x55); + /* DISCHGCNT3 - enable 100 ohm discharge on V1.8U_25U/V1.00A */ + i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x3e, 0x44); + /* DISCHGCNT4 - enable 100 ohm discharge on v1.8S */ + i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, 0x3f, 0x04); board_pmic_disable_slp_s0_vr_decay(); diff --git a/board/rammus/gpio.inc b/board/rammus/gpio.inc index fd0f8d5e14..b3f6e6ac97 100644 --- a/board/rammus/gpio.inc +++ b/board/rammus/gpio.inc @@ -61,7 +61,7 @@ GPIO(BRD_ID_EN, PIN(0, 2), GPIO_OUT_LOW) /* Enable f /* Reserved, for the lid accelerator interrupt */ GPIO(LID_ACCEL_INT_L, PIN(D, 2), GPIO_INPUT | GPIO_SEL_1P8V | GPIO_PULL_UP) /* LID Accelerator interrupt */ /* Reserved, changing touchpad interrupt behavior for wakeup */ -GPIO(TP_INT_CONN, PIN(C, 2), GPIO_INPUT | GPIO_PULL_UP) /* Touchpad interrupt */ +GPIO(TP_INT_CONN, PIN(C, 2), GPIO_INPUT) /* Touchpad interrupt */ /* Reserved, output low to enable touchpad interrupt by default */ GPIO(TP_INT_EN, PIN(A, 1), GPIO_OUT_LOW) /* Enable Touchpad interrupt */ |