diff options
| author | Boris Mittelberg <bmbm@google.com> | 2021-07-08 14:46:51 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-07-13 22:41:45 +0000 |
| commit | 48b421c7ffa43b09d2278f4c60ff4772df69dfee (patch) | |
| tree | b22889d4bba12ed8a59f7d2cb5d71c1e2d0a2646 | |
| parent | f8367c1b1828a19d03c8b593657add4289b038ef (diff) | |
| download | chrome-ec-48b421c7ffa43b09d2278f4c60ff4772df69dfee.tar.gz | |
TCPC: add flag to disable debug accessory control
The NCT38xx TCPC takes over the GPIO we otherwise use to control the
Burnside Bridge on Brya P1 devices. To get the BB out of reset we add
the flag to tcpc_config structure to take the control back to TCPM.
BRANCH=none
BUG=b:191516281
TEST=running deployment in the lab; running FAFT PD test
Signed-off-by: Boris Mittelberg <bmbm@google.com>
Change-Id: I73ddf26964cc6363640ddd80fbcbf353704d3198
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3016406
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | driver/tcpm/nct38xx.c | 2 | ||||
| -rw-r--r-- | include/usb_pd_tcpm.h | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/driver/tcpm/nct38xx.c b/driver/tcpm/nct38xx.c index fdd22c4119..469f67f18c 100644 --- a/driver/tcpm/nct38xx.c +++ b/driver/tcpm/nct38xx.c @@ -66,6 +66,8 @@ static int nct38xx_init(int port) (reg & TCPC_REG_POWER_STATUS_DEBUG_ACC_CON)) CPRINTS("C%d: Booted in dead battery mode, not changing debug" " control", port); + else if (tcpc_config[port].flags & TCPC_FLAGS_NO_DEBUG_ACC_CONTROL) + CPRINTS("C%d: NO_DEBUG_ACC_CONTROL", port); else RETURN_ERROR(tcpc_update8(port, TCPC_REG_TCPC_CTRL, TCPC_REG_TCPC_CTRL_DEBUG_ACC_CONTROL, diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index 584f3ac321..0902d411b5 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -478,12 +478,14 @@ struct tcpm_drv { * Bit 3 --> Set to 1 if TCPC is using TCPCI Revision 2.0 * Bit 4 --> Set to 1 if TCPC is using TCPCI Revision 2.0 but does not support * the vSafe0V bit in the EXTENDED_STATUS_REGISTER + * Bit 5 --> Set to 1 to prevent TCPC setting debug accessory control */ #define TCPC_FLAGS_ALERT_ACTIVE_HIGH BIT(0) #define TCPC_FLAGS_ALERT_OD BIT(1) #define TCPC_FLAGS_RESET_ACTIVE_HIGH BIT(2) #define TCPC_FLAGS_TCPCI_REV2_0 BIT(3) #define TCPC_FLAGS_TCPCI_REV2_0_NO_VSAFE0V BIT(4) +#define TCPC_FLAGS_NO_DEBUG_ACC_CONTROL BIT(5) struct tcpc_config_t { enum ec_bus_type bus_type; /* enum ec_bus_type */ |