diff options
| author | Sue Chen <sue.chen@quanta.corp-partner.google.com> | 2021-12-02 15:03:03 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-12-07 01:43:50 +0000 |
| commit | b7e4401fc2b5f1a923b48973b9c0e3cdb8d1c8aa (patch) | |
| tree | c53973d3c545ec2fcec18d4882cb1eac4a840d4b | |
| parent | 2d10ad31b6a667b3e38e901057e1ad186fe8a1cd (diff) | |
| download | chrome-ec-b7e4401fc2b5f1a923b48973b9c0e3cdb8d1c8aa.tar.gz | |
Dewatt: Modify LED color and LED behavior definition
Modify the color of EC_PWM_LED_FULL_L to blue,
LED spec:
Charging Amber on (S0/S3/S5)
Full Charged Blue on (S0/S3/S5)
Discharge in S3 Amber on 1sec, off 3sec
Discharge in S5 Off
Error Amber on 1sec, off 1sec
Discharge in S0 Blue on
Factory mode Blue on 2sec, Amber on 2 sec
BUG=b:208179462
BRANCH=none
TEST=LED behavior is correct for all states.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I9549c6b5c290b9d73fa9b18ec8d40480591c9a6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3312516
Reviewed-by: Rob Barnes <robbarnes@google.com>
| -rw-r--r-- | board/dewatt/led.c | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/board/dewatt/led.c b/board/dewatt/led.c index b17c8be488..de95a6396e 100644 --- a/board/dewatt/led.c +++ b/board/dewatt/led.c @@ -25,15 +25,16 @@ __override struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = { [STATE_CHARGING_LVL_1] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, [STATE_CHARGING_LVL_2] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, - [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} }, - [STATE_DISCHARGE_S0] = {{EC_LED_COLOR_WHITE, LED_INDEFINITE} }, - [STATE_DISCHARGE_S3] = {{EC_LED_COLOR_WHITE, 1 * LED_ONE_SEC}, - {LED_OFF, 1 * LED_ONE_SEC} }, + [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_COLOR_BLUE, LED_INDEFINITE} }, + [STATE_CHARGING_FULL_S5] = {{EC_LED_COLOR_BLUE, LED_INDEFINITE} }, + [STATE_DISCHARGE_S0] = {{EC_LED_COLOR_BLUE, LED_INDEFINITE} }, + [STATE_DISCHARGE_S3] = {{EC_LED_COLOR_AMBER, 1 * LED_ONE_SEC}, + {LED_OFF, 3 * LED_ONE_SEC} }, [STATE_DISCHARGE_S5] = {{LED_OFF, LED_INDEFINITE} }, [STATE_BATTERY_ERROR] = {{EC_LED_COLOR_AMBER, 1 * LED_ONE_SEC}, {LED_OFF, 1 * LED_ONE_SEC} }, [STATE_FACTORY_TEST] = {{EC_LED_COLOR_AMBER, 2 * LED_ONE_SEC}, - {EC_LED_COLOR_WHITE, 2 * LED_ONE_SEC} }, + {EC_LED_COLOR_BLUE, 2 * LED_ONE_SEC} }, }; const enum ec_led_id supported_led_ids[] = { @@ -49,7 +50,7 @@ __override void led_set_color_battery(enum ec_led_colors color) pwm_enable(PWM_CH_LED_CHRG, LED_ON_LVL); pwm_enable(PWM_CH_LED_FULL, LED_OFF_LVL); break; - case EC_LED_COLOR_WHITE: + case EC_LED_COLOR_BLUE: pwm_enable(PWM_CH_LED_CHRG, LED_OFF_LVL); pwm_enable(PWM_CH_LED_FULL, LED_ON_LVL); break; @@ -69,15 +70,15 @@ void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) { if (led_id == EC_LED_ID_BATTERY_LED) { brightness_range[EC_LED_COLOR_AMBER] = 1; - brightness_range[EC_LED_COLOR_WHITE] = 1; + brightness_range[EC_LED_COLOR_BLUE] = 1; } } int led_set_brightness(enum ec_led_id led_id, const uint8_t *brightness) { if (led_id == EC_LED_ID_BATTERY_LED) { - if (brightness[EC_LED_COLOR_WHITE] != 0) - led_set_color_battery(EC_LED_COLOR_WHITE); + if (brightness[EC_LED_COLOR_BLUE] != 0) + led_set_color_battery(EC_LED_COLOR_BLUE); else if (brightness[EC_LED_COLOR_AMBER] != 0) led_set_color_battery(EC_LED_COLOR_AMBER); else |