summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMary Ruthven <mruthven@chromium.org>2016-08-29 14:27:46 -0700
committerMary Ruthven <mruthven@chromium.org>2016-08-31 21:34:28 +0000
commiteb3f4b43f3efc2727d119f6b3a71a4ac7ac083d4 (patch)
treedaf80f917153b7ee737b2b336b2675982d74bc72
parent6c7fccf35674b09831dccd3ea8844990f041db8c (diff)
downloadchrome-ec-eb3f4b43f3efc2727d119f6b3a71a4ac7ac083d4.tar.gz
kevin: Add pullup to sys_rst_l
On boards using cr50 as the TPM there needs to be a pullup on SYS_RST_L BUG=chrome-os-partner:56701 BRANCH=none TEST=verify SYS_RST_L is pulled up on DVT1 and earlier. Change-Id: Ib87ef48bafe1dad1329678f9a80c34c7adc2df01 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/377504 Reviewed-by: Shawn N <shawnn@chromium.org>
-rw-r--r--board/kevin/board.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/board/kevin/board.c b/board/kevin/board.c
index 8428791fd3..628fcde0f4 100644
--- a/board/kevin/board.c
+++ b/board/kevin/board.c
@@ -387,8 +387,11 @@ int board_get_version(void)
*/
#ifdef BOARD_KEVIN
#define BOARD_VERSION_NEW_GPIO_CFG BOARD_VERSION_REV3
+#define BOARD_VERSION_DISCREET_TPM BOARD_VERSION_REV5
#else
#define BOARD_VERSION_NEW_GPIO_CFG BOARD_VERSION_REV1
+/* No version of gru has a discreet TPM */
+#define BOARD_VERSION_DISCREET_TPM BOARD_VERSION_COUNT
#endif
/* CONFIG removed in CL:351151. */
@@ -417,6 +420,10 @@ static void board_config_check(void)
{
int board_ver = board_get_version();
+ /* On Boards without a discreet TPM add a pullup to SYR_RST_L */
+ if (board_ver < BOARD_VERSION_DISCREET_TPM)
+ gpio_set_flags(GPIO_SYS_RST_L, GPIO_ODR_HIGH | GPIO_PULL_UP);
+
if (board_ver < BOARD_VERSION_NEW_GPIO_CFG)
hook_call_deferred(&board_config_warning_data, 0);
}