summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@chromium.org>2018-01-17 11:53:12 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-01-17 06:20:38 -0800
commite71899a5734b151b79db896b88f00cac14b8e50a (patch)
treeea11cba93c4b7066ad349b1fb0e71b8e04c63da9
parentc10a631026fb02b356435f4f7d150495b2cec223 (diff)
downloadchrome-ec-e71899a5734b151b79db896b88f00cac14b8e50a.tar.gz
ectool: battery: Allow negative present current
Battery interface over host command is different, as it allows negative current values to indicate discharge, let's not fail in that case. BRANCH=none BUG=b:65697620 TEST=ectool battery 1 does not fail when battery is discharging. Change-Id: I89ca750e24706f55a0589201aeaf9fea50f3132f Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/869552 Reviewed-by: Randall Spangler <rspangler@chromium.org>
-rw-r--r--util/ectool.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/util/ectool.c b/util/ectool.c
index 200b2faacf..c241b885c1 100644
--- a/util/ectool.c
+++ b/util/ectool.c
@@ -5977,9 +5977,8 @@ int get_battery_command(int index)
goto cmd_error;
printf(" Present voltage %u mV\n", dynamic_r.actual_voltage);
- if (!is_battery_range(dynamic_r.actual_current))
- goto cmd_error;
- printf(" Present current %u mA\n", dynamic_r.actual_current);
+ /* current can be negative */
+ printf(" Present current %d mA\n", dynamic_r.actual_current);
if (!is_battery_range(dynamic_r.remaining_capacity))
goto cmd_error;