summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Chen <philipchen@google.com>2018-01-11 12:16:21 -0800
committerchrome-bot <chrome-bot@chromium.org>2018-01-16 21:26:28 -0800
commit1e1b5d4463c2f273c593f90fd1f60b7c06139f86 (patch)
tree66b9d027de327ece0daac68580a716ade18d3ea6
parent0348eb1059cd4fa43b8426013314f76ac201bd7a (diff)
downloadchrome-ec-1e1b5d4463c2f273c593f90fd1f60b7c06139f86.tar.gz
power/rk3399: Change power-off sequence for KD panel
We should turn off PP3300_S0 and then PP1800_S0 to meet KD panel spec. PP3300_S0 has to be on in S3_WoUSB, so PP1800_S0 also has to be on - let's move PP1800_S0_EN to s0s3_usb_wake_power_seq. BUG=b:71057948 BRANCH=none TEST='suspend_stress_test' for 10+ cycles without seeing things go wrong Change-Id: Ic44411062b4c9e857b9f8ca6565550ba8bd2f950 Signed-off-by: Philip Chen <philipchen@google.com> Reviewed-on: https://chromium-review.googlesource.com/862254 Commit-Ready: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org>
-rw-r--r--power/rk3399.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/power/rk3399.c b/power/rk3399.c
index b429556d5c..b264816f72 100644
--- a/power/rk3399.c
+++ b/power/rk3399.c
@@ -150,7 +150,6 @@ static const struct power_seq_op s3s0_usb_wake_power_seq[] = {
/* The power sequence for POWER_S0S3 */
#if CONFIG_CHIPSET_POWER_SEQ_VERSION == 2
static const struct power_seq_op s0s3_power_seq[] = {
- { GPIO_PP1800_S0_EN, 0, 1 },
{ GPIO_AP_CORE_EN, 0, 20 },
};
#else
@@ -168,6 +167,7 @@ static const struct power_seq_op s0s3_power_seq[] = {
/* Sigs that need to be left on in S3, if we need to wake-on-USB */
static const struct power_seq_op s0s3_usb_wake_power_seq[] = {
{ GPIO_PP3300_S0_EN, 0, 20 },
+ { GPIO_PP1800_S0_EN, 0, 1 },
{ GPIO_PP1800_USB_EN, 0, 1 },
};
#endif