diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2017-09-07 12:44:10 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-01-10 15:44:33 -0800 |
| commit | c1ad33b24db07814069c1c8f6ce1806bd3e1e5b4 (patch) | |
| tree | fa26cec3d1245b2de23b84a2e36486eef2be3c24 | |
| parent | 179c624133b5fa33d736fcb00957e2bd1b6b6244 (diff) | |
| download | chrome-ec-c1ad33b24db07814069c1c8f6ce1806bd3e1e5b4.tar.gz | |
cr50: enable deep sleep on Bob
Enable deep sleep on rk3399 devices and start using SYS_RST_L to track
the AP state.
We can only release this once the EC has the proper support. It needs to
assert SYS_RST_L in S5.
If we have an old EC and this change in the Cr50 firmware, Cr50 won't be
able to tell when the AP is off. I think this will just cause an
interrupt storm on the AP UART and might not go into regular sleep in
S5.
If the EC change gets released before Cr50, Cr50 won't go to sleep in
S5, because SYS_RST_L is a wake on low pin. Cr50 will immediately wake
up from the SYS_RST_L pin when it enters sleep.
BUG=b:35647982
BRANCH=cr50
TEST=run firmware_Cr50DeepSleepStress on Bob
Change-Id: Iaf46f46eb5963e9479bba40457253a6ccc91ad32
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/699295
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | board/cr50/board.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/board/cr50/board.c b/board/cr50/board.c index bcb01951bc..04b64d1dac 100644 --- a/board/cr50/board.c +++ b/board/cr50/board.c @@ -236,8 +236,7 @@ const struct strap_desc strap_regs[] = { static struct board_cfg board_cfg_table[] = { /* SPI Variants: DIOA12 = 1M PD, DIOA6 = 1M PD */ /* Kevin/Gru: DI0A9 = 5k PD, DIOA1 = 1M PU */ - { 0x02, BOARD_SLAVE_CONFIG_SPI | BOARD_NEEDS_SYS_RST_PULL_UP | - BOARD_DEEP_SLEEP_DISABLED | BOARD_DETECT_AP_WITH_UART }, + { 0x02, BOARD_SLAVE_CONFIG_SPI | BOARD_NEEDS_SYS_RST_PULL_UP }, /* Poppy: DI0A9 = 1M PU, DIOA1 = 1M PU */ { 0x0A, BOARD_SLAVE_CONFIG_SPI | BOARD_USE_PLT_RESET }, |