diff options
| author | Tom Wai-Hong Tam <waihong@google.com> | 2018-05-01 15:13:50 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-05-09 14:40:02 -0700 |
| commit | 4461fb7ab7c5d264126040d6588866ed43dde9ed (patch) | |
| tree | 98fe734923268e5837686326afd3db70331958b1 | |
| parent | aafc4f5d1aa5ee0f67cf0e391acc68309eaa8c92 (diff) | |
| download | chrome-ec-4461fb7ab7c5d264126040d6588866ed43dde9ed.tar.gz | |
cheza: Remove BC1.2 switch hack
PD is enabled so don't need it.
BRANCH=none
BUG=b:74395451
TEST=Did "gpioset EN_PP5000_A 1" before the folllowing tests:
* Verified USB boot
* Plugged adapter to port-0/port-1/both and saw charging
* Plugged USB device to port-0/port-1/both and saw sourcing VBUS
* Plugged adapter to one port and USB device to another port
* Plugged USB disk to port-0 and booted into kernel
* When AP off, not sourcing VBUS to USB device
* Rebooting AP still works
Change-Id: Ib878960fb302d85549735a395f75cc8d045d45f2
Signed-off-by: Tom Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1042621
Commit-Ready: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
| -rw-r--r-- | board/cheza/board.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/board/cheza/board.c b/board/cheza/board.c index b3ebcf8bb9..ac80be40bc 100644 --- a/board/cheza/board.c +++ b/board/cheza/board.c @@ -49,7 +49,6 @@ static void anx74xx_cable_det_interrupt(enum gpio_signal signal); #include "gpio_list.h" /* 8-bit I2C address */ -#define PI3USB9281_I2C_ADDR 0x4a #define DA9313_I2C_ADDR 0xd0 #define CHARGER_I2C_ADDR 0x12 @@ -231,19 +230,6 @@ BUILD_ASSERT(ARRAY_SIZE(pi3usb9281_chips) == static void board_init(void) { /* - * Hack to enable the internal switch in BC1.2 - * TODO(waihong): Enable BC1.2 autodetection. - */ - i2c_write8(I2C_PORT_TCPC0, PI3USB9281_I2C_ADDR, PI3USB9281_REG_CONTROL, - 0x1b); /* Manual switch on port-0 */ - i2c_write8(I2C_PORT_TCPC0, PI3USB9281_I2C_ADDR, PI3USB9281_REG_MANUAL, - 0x24); /* Connection of D+ and D- */ - i2c_write8(I2C_PORT_TCPC1, PI3USB9281_I2C_ADDR, PI3USB9281_REG_CONTROL, - 0x1b); /* Manual switch on port-1 */ - i2c_write8(I2C_PORT_TCPC1, PI3USB9281_I2C_ADDR, PI3USB9281_REG_MANUAL, - 0x24); /* Connection of D+ and D- */ - - /* * Disable SwitchCap auto-boot and make EN pin level-trigger * TODO(b/77957956): Remove it after hardware fix. */ |