diff options
author | Raymond Chou <raymond_chou@compal.corp-partner.google.com> | 2018-04-24 21:06:23 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-05-17 19:35:00 -0700 |
commit | da9d652117a541843824dce6708b589bb3f45808 (patch) | |
tree | a4693ae00b6d90bf8b2a54ee94eafc81c95b3664 | |
parent | 65b05ac7b128e871dcbe55cc5fdcb6612448ab2d (diff) | |
download | chrome-ec-da9d652117a541843824dce6708b589bb3f45808.tar.gz |
Nami: Allow ectool to control LEDs
This patch makes led_get_brightness_range return amber=100, white=100
regardless of OEM ID or led_id. This function is for ectool led command,
which is used to test basic LED connectivity.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:78489297,b:77827579
BRANCH=none
TEST=Run
1. ectool led battery white=100
2. ectool led battery amber=100
3. ectool led power white=100
4. ectool led power amber=100
Change-Id: I6c6b3a5dd26aaba3a3ff7dccd6e116794c6594c9
Reviewed-on: https://chromium-review.googlesource.com/1062077
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
-rw-r--r-- | board/nami/led.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/board/nami/led.c b/board/nami/led.c index 4ce440ba80..70d4b0f689 100644 --- a/board/nami/led.c +++ b/board/nami/led.c @@ -526,19 +526,21 @@ DECLARE_CONSOLE_COMMAND(led, command_led, void led_get_brightness_range(enum ec_led_id led_id, uint8_t *brightness_range) { - brightness_range[EC_LED_COLOR_RED] = 100; - brightness_range[EC_LED_COLOR_GREEN] = 100; + /* + * We return amber=100, white=100 regardless of OEM ID or led_id. This + * function is for ectool led command, which is used to test LED + * functionality. + */ brightness_range[EC_LED_COLOR_AMBER] = 100; + brightness_range[EC_LED_COLOR_WHITE] = 100; } int led_set_brightness(enum ec_led_id id, const uint8_t *brightness) { - if (brightness[EC_LED_COLOR_RED]) - return set_color(id, LED_RED, brightness[EC_LED_COLOR_RED]); - else if (brightness[EC_LED_COLOR_GREEN]) - return set_color(id, LED_GREEN, brightness[EC_LED_COLOR_GREEN]); - else if (brightness[EC_LED_COLOR_AMBER]) + if (brightness[EC_LED_COLOR_AMBER]) return set_color(id, LED_AMBER, brightness[EC_LED_COLOR_AMBER]); + else if (brightness[EC_LED_COLOR_WHITE]) + return set_color(id, LED_WHITE, brightness[EC_LED_COLOR_WHITE]); else return set_color(id, LED_OFF, 0); } |