diff options
| author | Edward Hill <ecgh@chromium.org> | 2018-10-03 13:14:59 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-04 00:37:05 -0700 |
| commit | 5749693065ab209deee0a66e749302abd337b01c (patch) | |
| tree | de50ca6b07730fec66fcb44031d10fa12b0bbd0e | |
| parent | c7df731221c3ae8bf24aa032bdb279f29bd0bf6f (diff) | |
| download | chrome-ec-5749693065ab209deee0a66e749302abd337b01c.tar.gz | |
grunt: Reduce PD turn off delay
Reduce PD_POWER_SUPPLY_TURN_OFF_DELAY to 30 milliseconds. Thanks
to PPC VBUS discharge, VBUS drops below 0.8V (vSafe0V) in well
under 10 milliseconds.
Also remove TODO comments for adjusting PD values, since these
all appear correct now.
BUG=b:69683108,b:69683178
BRANCH=grunt
TEST=check VBUS rise and fall on scope
Change-Id: I506851e13850dddda97ae9582a5c0aa7d66882c3
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1259385
Reviewed-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | baseboard/grunt/baseboard.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/baseboard/grunt/baseboard.h b/baseboard/grunt/baseboard.h index 2dd088009c..0af8971061 100644 --- a/baseboard/grunt/baseboard.h +++ b/baseboard/grunt/baseboard.h @@ -129,12 +129,10 @@ #define CONFIG_USB_PORT_POWER_DUMB #define USB_PORT_COUNT 2 -/* TODO(b/69683108): Use correct PD delay values */ -#define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */ -#define PD_POWER_SUPPLY_TURN_OFF_DELAY 250000 /* us */ +#define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */ +#define PD_POWER_SUPPLY_TURN_OFF_DELAY 30000 /* us */ #define PD_VCONN_SWAP_DELAY 5000 /* us */ -/* TODO(b/69683178): Use correct PD power values */ #define PD_OPERATING_POWER_MW 15000 #define PD_MAX_POWER_MW 45000 #define PD_MAX_CURRENT_MA 3000 |