diff options
| author | Wai-Hong Tam <waihong@google.com> | 2018-10-25 17:08:51 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-31 21:59:15 -0700 |
| commit | f988a2f81baa46dc0207d47684b2c87d19fd96ae (patch) | |
| tree | 4e2894b8e8ccf038eb2af9149120f0115fce274a | |
| parent | 8d652217d9a006985b58126aa25277ac2c79263d (diff) | |
| download | chrome-ec-f988a2f81baa46dc0207d47684b2c87d19fd96ae.tar.gz | |
cheza: Remove the internal PU for UART pins
It is not needed; otherwise, it pulls the UART_DB_TX_EC_RX
to 1.8V and and may affect cr50 servo detection.
BRANCH=none
BUG=b:117296184
TEST=Measured the voltage level of UART_DBG_TX_EC_RX.
When servo plugged and CCD unplugged, it shows 3.3V.
When servo unplugged and CCD unplugged, it shows 0V (was 1.8V).
When servo unplugged and CCD plugged, it shows 3.3V.
EC console works over either servo and CCD.
Change-Id: Ie81d1de0075ea1b2409131471fe8571b5bfdccd1
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1302839
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
| -rw-r--r-- | board/cheza/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/cheza/gpio.inc b/board/cheza/gpio.inc index 705bb38dad..c721f94b73 100644 --- a/board/cheza/gpio.inc +++ b/board/cheza/gpio.inc @@ -155,7 +155,7 @@ GPIO(SKU_ID2, PIN(4, 1), GPIO_INPUT) GPIO(DA9313_GPIO0, PIN(E, 2), GPIO_INPUT | GPIO_PULL_DOWN) /* Switchcap GPIO0 */ /* Alternate functions GPIO definitions */ -ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, GPIO_PULL_UP) /* UART (GPIO64/65) */ +ALTERNATE(PIN_MASK(6, 0x30), 0, MODULE_UART, 0) /* UART (GPIO64/65) */ ALTERNATE(PIN_MASK(B, 0x30), 1, MODULE_I2C, 0) /* I2C0 (GPIOB4/B5) */ ALTERNATE(PIN_MASK(9, 0x07), 1, MODULE_I2C, 0) /* I2C1 SDA (GPIO90), I2C2 (GPIO91/92) */ ALTERNATE(PIN_MASK(8, 0x80), 1, MODULE_I2C, 0) /* I2C1 SCL (GPIO87) */ |