diff options
| author | Jett Rink <jettrink@chromium.org> | 2019-01-02 14:12:57 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-01-05 20:08:40 -0800 |
| commit | ef15468753984a9d4ee71ea1c73fc7899e977802 (patch) | |
| tree | 523988bc1762827ebce87b1761757ac60e4cfe5f | |
| parent | dd3955cf551e707f91c37f92c9198bd0f6af9d97 (diff) | |
| download | chrome-ec-ef15468753984a9d4ee71ea1c73fc7899e977802.tar.gz | |
octopus: reduce all octopus sensor fifo sizes
Too large of a FIFO causes jitter in the sensor timestamp which can
cause issues during batch CTS tests.
BRANCH=octopus
BUG=b:120508077
TEST=everything builds. Test with smaller fifo were done on bobba. See
CL:1387348
Change-Id: If67a46faa6e136006a20ac243b826b7ce06d9868
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1392425
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
| -rw-r--r-- | baseboard/octopus/baseboard.h | 10 | ||||
| -rw-r--r-- | board/ampton/board.h | 6 | ||||
| -rw-r--r-- | board/bobba/board.h | 5 | ||||
| -rw-r--r-- | board/fleex/board.h | 6 | ||||
| -rw-r--r-- | board/meep/board.h | 6 | ||||
| -rw-r--r-- | board/phaser/board.h | 9 | ||||
| -rw-r--r-- | board/yorp/board.h | 6 |
7 files changed, 10 insertions, 38 deletions
diff --git a/baseboard/octopus/baseboard.h b/baseboard/octopus/baseboard.h index 05fe75d512..1b91245da0 100644 --- a/baseboard/octopus/baseboard.h +++ b/baseboard/octopus/baseboard.h @@ -269,6 +269,16 @@ #undef CONFIG_MOTION_SENSE_RESUME_DELAY_US #define CONFIG_MOTION_SENSE_RESUME_DELAY_US (10 * MSEC) +/* + * Interrupt and fifo are only used for base accelerometer + * and the lid sensor is polled real-time (in forced mode). + */ +#define CONFIG_ACCEL_INTERRUPTS +/* Power of 2 - Too large of a fifo causes too much timestamp jitter */ +#define CONFIG_ACCEL_FIFO 256 +/* Depends on how fast the AP boots and typical ODRs */ +#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) + #ifndef __ASSEMBLER__ #include "gpio_signal.h" diff --git a/board/ampton/board.h b/board/ampton/board.h index c90dc72cab..908ca8fb07 100644 --- a/board/ampton/board.h +++ b/board/ampton/board.h @@ -52,12 +52,6 @@ #define CONFIG_LID_ANGLE_SENSOR_BASE BASE_ACCEL #define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL -#define CONFIG_ACCEL_INTERRUPTS -/* FIFO size is in power of 2. */ -#define CONFIG_ACCEL_FIFO 1024 - -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_MKBP_EVENT #define CONFIG_ACCELGYRO_BMI160_INT_EVENT TASK_EVENT_CUSTOM(1 << 2) diff --git a/board/bobba/board.h b/board/bobba/board.h index 224fff5737..92331821f9 100644 --- a/board/bobba/board.h +++ b/board/bobba/board.h @@ -31,11 +31,6 @@ /* Sensors without hardware FIFO are in forced mode */ #define CONFIG_ACCEL_FORCE_MODE_MASK (1 << LID_ACCEL) -#define CONFIG_ACCEL_INTERRUPTS -#define CONFIG_ACCEL_FIFO 256 /* Power of 2 */ -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) - /* Motion Sense Task Events */ #define CONFIG_ACCELGYRO_BMI160_INT_EVENT TASK_EVENT_CUSTOM(1 << 2) #define CONFIG_SYNC_INT_EVENT TASK_EVENT_CUSTOM(1 << 3) diff --git a/board/fleex/board.h b/board/fleex/board.h index 9255bf861c..ee28d41e9f 100644 --- a/board/fleex/board.h +++ b/board/fleex/board.h @@ -42,12 +42,6 @@ #define CONFIG_STEINHART_HART_3V3_13K7_47K_4050B #define CONFIG_STEINHART_HART_3V3_51K1_47K_4050B -#define CONFIG_ACCEL_INTERRUPTS -/* FIFO size is in power of 2. */ -#define CONFIG_ACCEL_FIFO 1024 - -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_MKBP_EVENT #define CONFIG_MKBP_USE_HOST_EVENT diff --git a/board/meep/board.h b/board/meep/board.h index 029e833d2e..69e6279403 100644 --- a/board/meep/board.h +++ b/board/meep/board.h @@ -43,12 +43,6 @@ #define CONFIG_STEINHART_HART_3V3_13K7_47K_4050B #define CONFIG_STEINHART_HART_3V3_51K1_47K_4050B -#define CONFIG_ACCEL_INTERRUPTS -/* FIFO size is in power of 2. */ -#define CONFIG_ACCEL_FIFO 1024 - -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_MKBP_EVENT #define CONFIG_MKBP_USE_HOST_EVENT diff --git a/board/phaser/board.h b/board/phaser/board.h index d86b93dc84..0b5d262d49 100644 --- a/board/phaser/board.h +++ b/board/phaser/board.h @@ -40,15 +40,6 @@ #define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL #define CONFIG_DYNAMIC_MOTION_SENSOR_COUNT -/* Interrupt and fifo are only used for base accelerometer - * and the lid sensor is polled real-time (in forced mode). - */ -#define CONFIG_ACCEL_INTERRUPTS -/* FIFO size is in power of 2. */ -#define CONFIG_ACCEL_FIFO 1024 - -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_MKBP_EVENT #define CONFIG_MKBP_USE_HOST_EVENT diff --git a/board/yorp/board.h b/board/yorp/board.h index d0200ce6f2..c0521e717a 100644 --- a/board/yorp/board.h +++ b/board/yorp/board.h @@ -39,12 +39,6 @@ #define CONFIG_STEINHART_HART_3V3_13K7_47K_4050B #define CONFIG_STEINHART_HART_3V3_51K1_47K_4050B -#define CONFIG_ACCEL_INTERRUPTS -/* FIFO size is in power of 2. */ -#define CONFIG_ACCEL_FIFO 1024 - -/* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_MKBP_EVENT #define CONFIG_MKBP_USE_HOST_EVENT |