diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2019-01-07 13:00:29 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-01-14 23:11:40 -0800 |
| commit | f6002d4b37d7d2697ee27a4385ad87f5165df7da (patch) | |
| tree | 64d76150b3f73c5431234a40c4471460c14e5e4f | |
| parent | 9c16be4ddd6f8bb19c3cbc7db9c0a4dae877a8d6 (diff) | |
| download | chrome-ec-f6002d4b37d7d2697ee27a4385ad87f5165df7da.tar.gz | |
nocturne: Raise ATTACH_MAX_MV to 900.
There are some devices where when connected to whiskers, the base attach
ADC reading is right on the threshold for max. This may cause whiskers
to not be powered appearing as the keyboard not working. This commit
simply increases the threshold to 900mV to allow more whiskers to be
detected.
BUG=b:122361740
BRANCH=firmware-nocturne-10984.B
TEST=`make -j buildall`
Change-Id: I10e2d58e5277abdd28a50a3aca3ef0f26d93aeba
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1399186
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
(cherry picked from commit 845edf693b9fc305a74ec4baa4b238c144dcc0d1)
Reviewed-on: https://chromium-review.googlesource.com/1409493
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
| -rw-r--r-- | board/nocturne/base_detect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/nocturne/base_detect.c b/board/nocturne/base_detect.c index d9fc6904cf..70600388f9 100644 --- a/board/nocturne/base_detect.c +++ b/board/nocturne/base_detect.c @@ -39,7 +39,7 @@ /* Thresholds for attach pin reading when power is not applied. */ #define ATTACH_MIN_MV 300 -#define ATTACH_MAX_MV 800 +#define ATTACH_MAX_MV 900 /* Threshold for attach pin reading when power IS applied. */ #define PWREN_ATTACH_MIN_MV 2300 |