diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-02-06 16:33:44 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-02-15 01:55:24 -0800 |
| commit | e890d0974cf300ed56ae3df468c687528512ae61 (patch) | |
| tree | ffbeb10d0f48191e11bafcad0d3f03521b6c3a67 | |
| parent | 751fb79680b3477ad0f6c7530cdc673b015d0673 (diff) | |
| download | chrome-ec-e890d0974cf300ed56ae3df468c687528512ae61.tar.gz | |
CBI: Use hexdump to dump EEPROM contents
The hexdump API can dump binary data in more useful and common format:
43 42 49 ca 00 00 13 00 00 02 01 03 01 01 03 02 |CBI.............|
02 67 3a ff ff ff ff ff ff ff ff ff ff ff ff ff |.g:.............|
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=Run cbi command.
Change-Id: I4bc6e968351103aa87139398b35aa095aa63c443
Reviewed-on: https://chromium-review.googlesource.com/1457578
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
| -rw-r--r-- | common/cbi.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/common/cbi.c b/common/cbi.c index 8ec4472b24..e4dc001184 100644 --- a/common/cbi.c +++ b/common/cbi.c @@ -335,14 +335,11 @@ static void dump_flash(void) uint8_t buf[16]; int i; for (i = 0; i < CBI_EEPROM_SIZE; i += sizeof(buf)) { - int j; if (read_eeprom(i, buf, sizeof(buf))) { ccprintf("\nFailed to read EEPROM\n"); return; } - for (j = 0; j < sizeof(buf); j++) - ccprintf(" %02x", buf[j]); - ccprintf("\n"); + hexdump(buf, sizeof(buf)); } } |