diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-10-03 10:02:37 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-04 00:37:03 -0700 |
| commit | c7df731221c3ae8bf24aa032bdb279f29bd0bf6f (patch) | |
| tree | 04226db42f3e98cdc08872367b819422d2e9eae5 | |
| parent | 58db3a6828425fcd2f1ca961c52d5d7803adafd9 (diff) | |
| download | chrome-ec-c7df731221c3ae8bf24aa032bdb279f29bd0bf6f.tar.gz | |
octopus: remove CONFIG_SYSTEM_UNLOCKED option
For all NPCX boards, remove the CONFIG_SYSTEM_UNLOCKED option. The main
affect of this will be to prevent PD communication in RO. We are
starting to get into factory test that want to verify this behavior. As a
developer, one must remember to jump to RW before PD will negotiate.
BRANCH=none
BUG=b:117109816
TEST=flash on fleex and RO did not negotiate (when WP was asserted)
but RW did.
Change-Id: I2df575baad95a334a4a57a9f81600fc039157fd5
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1258568
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
| -rw-r--r-- | board/bobba/board.h | 3 | ||||
| -rw-r--r-- | board/fleex/board.h | 3 | ||||
| -rw-r--r-- | board/meep/board.h | 3 | ||||
| -rw-r--r-- | board/phaser/board.h | 3 | ||||
| -rw-r--r-- | board/yorp/board.h | 3 |
5 files changed, 0 insertions, 15 deletions
diff --git a/board/bobba/board.h b/board/bobba/board.h index d790afc516..f8a05776bf 100644 --- a/board/bobba/board.h +++ b/board/bobba/board.h @@ -16,9 +16,6 @@ /* I2C bus configuraiton */ #define I2C_PORT_ACCEL I2C_PORT_SENSOR -/* Optional features */ -#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ - /* EC console commands */ #define CONFIG_CMD_ACCELS #define CONFIG_CMD_ACCEL_INFO diff --git a/board/fleex/board.h b/board/fleex/board.h index 625be8387c..1e8927d3e9 100644 --- a/board/fleex/board.h +++ b/board/fleex/board.h @@ -13,9 +13,6 @@ #define VARIANT_OCTOPUS_CHARGER_ISL9238 #include "baseboard.h" -/* Optional features */ -#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ - /* EC console commands */ #define CONFIG_CMD_ACCELS #define CONFIG_CMD_ACCEL_INFO diff --git a/board/meep/board.h b/board/meep/board.h index c19c667492..19654807d4 100644 --- a/board/meep/board.h +++ b/board/meep/board.h @@ -17,9 +17,6 @@ #define GPIO_VOLUME_UP_L GPIO_EC_VOLUP_BTN_ODL #define GPIO_VOLUME_DOWN_L GPIO_EC_VOLDN_BTN_ODL -/* Optional features */ -#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ - /* EC console commands */ #define CONFIG_CMD_ACCELS #define CONFIG_CMD_ACCEL_INFO diff --git a/board/phaser/board.h b/board/phaser/board.h index 0a511969ac..d1d60d0ea2 100644 --- a/board/phaser/board.h +++ b/board/phaser/board.h @@ -21,9 +21,6 @@ #define GPIO_VOLUME_UP_L GPIO_EC_VOLUP_BTN_ODL #define GPIO_VOLUME_DOWN_L GPIO_EC_VOLDN_BTN_ODL -/* Optional features */ -#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ - #define CONFIG_LED_COMMON #define OCTOPUS_POWER_LED #define CONFIG_TEMP_SENSOR diff --git a/board/yorp/board.h b/board/yorp/board.h index b588ee4898..d11b8fc868 100644 --- a/board/yorp/board.h +++ b/board/yorp/board.h @@ -13,9 +13,6 @@ #define VARIANT_OCTOPUS_CHARGER_ISL9238 #include "baseboard.h" -/* Optional features */ -#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */ - /* EC console commands */ #define CONFIG_CMD_ACCELS #define CONFIG_CMD_ACCEL_INFO |