summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJack Rosenthal <jrosenth@chromium.org>2019-05-16 15:03:53 -0600
committerchrome-bot <chrome-bot@chromium.org>2019-05-17 18:37:29 -0700
commitcd45a75e8c0dea45b94dc530fde7c86cc698fd2d (patch)
tree4bbdb9b091c4c53067882f9f6aa285fd9f1012ec
parent7495960f1f6f780fa63a57b9caaddbb82bdd2a32 (diff)
downloadchrome-ec-cd45a75e8c0dea45b94dc530fde7c86cc698fd2d.tar.gz
common: chip_save_reset_flags takes uint32_t
The getters and setters for the reset flags should take and return the same type. `uint32_t' seems the more appropraiate type than `int', so change the setter to take `uint32_t'. BUG=none BRANCH=none TEST=make buildall -j Change-Id: I50928a114858dd51034a048520efa849f5182bd0 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1615648 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
-rw-r--r--chip/ish/system.c2
-rw-r--r--chip/mchp/system.c2
-rw-r--r--chip/mec1322/system.c2
-rw-r--r--chip/npcx/system.c2
-rw-r--r--include/system.h2
5 files changed, 5 insertions, 5 deletions
diff --git a/chip/ish/system.c b/chip/ish/system.c
index 560a71678b..1af3499f62 100644
--- a/chip/ish/system.c
+++ b/chip/ish/system.c
@@ -46,7 +46,7 @@ void system_pre_init(void)
system_set_reset_flags(chip_read_reset_flags());
}
-void chip_save_reset_flags(int flags)
+void chip_save_reset_flags(uint32_t flags)
{
ISH_RESET_FLAGS = flags;
}
diff --git a/chip/mchp/system.c b/chip/mchp/system.c
index 689675716d..3117638bd5 100644
--- a/chip/mchp/system.c
+++ b/chip/mchp/system.c
@@ -199,7 +199,7 @@ void system_pre_init(void)
spi_enable(CONFIG_SPI_FLASH_PORT, 1);
}
-void chip_save_reset_flags(int flags)
+void chip_save_reset_flags(uint32_t flags)
{
MCHP_VBAT_RAM(HIBDATA_INDEX_SAVED_RESET_FLAGS) = flags;
}
diff --git a/chip/mec1322/system.c b/chip/mec1322/system.c
index 4431ee6954..38b895c471 100644
--- a/chip/mec1322/system.c
+++ b/chip/mec1322/system.c
@@ -93,7 +93,7 @@ void system_pre_init(void)
spi_enable(CONFIG_SPI_FLASH_PORT, 1);
}
-void chip_save_reset_flags(int flags)
+void chip_save_reset_flags(uint32_t flags)
{
MEC1322_VBAT_RAM(HIBDATA_INDEX_SAVED_RESET_FLAGS) = flags;
}
diff --git a/chip/npcx/system.c b/chip/npcx/system.c
index aa0c6fbb51..c37b85934b 100644
--- a/chip/npcx/system.c
+++ b/chip/npcx/system.c
@@ -317,7 +317,7 @@ static void chip_panic_data_restore(void)
}
#endif /* CONFIG_CHIP_PANIC_BACKUP */
-void chip_save_reset_flags(int flags)
+void chip_save_reset_flags(uint32_t flags)
{
bbram_data_write(BBRM_DATA_INDEX_SAVED_RESET_FLAGS, flags);
}
diff --git a/include/system.h b/include/system.h
index 0411ab71eb..e1eec86998 100644
--- a/include/system.h
+++ b/include/system.h
@@ -37,7 +37,7 @@
#define RESET_FLAG_AP_WATCHDOG BIT(18) /* AP experienced a watchdog reset */
/* Per chip implementation to save/read raw RESET_FLAG_ flags. */
-void chip_save_reset_flags(int flags);
+void chip_save_reset_flags(uint32_t flags);
uint32_t chip_read_reset_flags(void);
/* System images */