summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Collyer <scollyer@google.com>2019-06-26 11:04:23 -0700
committerCommit Bot <commit-bot@chromium.org>2019-07-02 02:25:58 +0000
commit0e662b07aae39979e65637e80f5baecbf0a92a0f (patch)
tree5e67bf87f2cbb21f35c349578df7c35e2bbec632
parent971d8de3d13bd7efc9b2199d926dfe1f9681aa3a (diff)
downloadchrome-ec-0e662b07aae39979e65637e80f5baecbf0a92a0f.tar.gz
dptf: Prevent sensor warning in G3
This CL adds a check for chipset state to prevent the console message "can't read any temp sensors!" from being displayed when the AP is in G3. It is likely that temp sensors are tied to a rail that's not up in the G3 state. BUG=b:123900860 BRANCH=Master TEST=Put the AP in G3 and verified that the console message is no longer displayed. Change-Id: Iee8549b8d2425bbc42972d704ebc931bbe6c2690 Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1679041 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Auto-Submit: Scott Collyer <scollyer@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
-rw-r--r--common/dptf.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/common/dptf.c b/common/dptf.c
index c7623ce479..acc04b123f 100644
--- a/common/dptf.c
+++ b/common/dptf.c
@@ -4,6 +4,7 @@
*/
#include "atomic.h"
+#include "chipset.h"
#include "common.h"
#include "console.h"
#include "dptf.h"
@@ -156,7 +157,8 @@ static void thermal_control_dptf(void)
* bus to the sensors; forcing a shutdown in that case would
* merely hamper board bringup.
*/
- smi_sensor_failure_warning();
+ if (!chipset_in_state(CHIPSET_STATE_HARD_OFF))
+ smi_sensor_failure_warning();
}
/* Don't forget to signal any DPTF thresholds */