diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2019-07-30 15:25:37 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-31 00:40:17 +0000 |
| commit | da820cb63d93ab94d44b070a0ee8b8d4c2074f92 (patch) | |
| tree | bf007fcef2fc2e554591c751408e00476b366674 | |
| parent | d754f92d3beb9b1d7d19ec081c39dd87b964473f (diff) | |
| download | chrome-ec-da820cb63d93ab94d44b070a0ee8b8d4c2074f92.tar.gz | |
util/ec_flash: avoid divide-by-zero
BUG=none
BRANCH=none
TEST=none
Change-Id: I514c2aa307e94be826e9c8e219eb471892b3fad6
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #201954
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1725951
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Auto-Submit: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
| -rw-r--r-- | util/ec_flash.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/util/ec_flash.c b/util/ec_flash.c index 0ae32403d4..3bae077200 100644 --- a/util/ec_flash.c +++ b/util/ec_flash.c @@ -153,6 +153,13 @@ int ec_flash_write(const uint8_t *buf, int offset, int size) if (write_size < 0) return write_size; + /* + * shouldn't ever happen, but report an error rather than a division + * by zero in the next statement. + */ + if (write_size == 0) + return -1; + step = (pdata_max_size / write_size) * write_size; if (!step) { |