diff options
| author | Keith Short <keithshort@chromium.org> | 2019-08-09 13:57:59 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-12 19:03:29 +0000 |
| commit | 99591a03f7e9b3680d80e7cd040d7f437da1dfb1 (patch) | |
| tree | 9a0ce1386a9af22562ee735ce7d7df1fa1a3fee7 | |
| parent | c090c1101c7d1c87ee706d67be29d74eae9f541e (diff) | |
| download | chrome-ec-99591a03f7e9b3680d80e7cd040d7f437da1dfb1.tar.gz | |
hatch: SLP_S3/S4 sideband signals guarded with wrong config
All the hatch platforms had a typo with the config option guarding the
configuration of the SLP_S3_L and SLP_S4_L signals. Changed
CONFIG_HOSTCMD_ESPI_VW_SIGNALS to CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS.
BUG=b:139198212
BRANCH=none
TEST=make buildall -j
Change-Id: I96c01fb8e1903585f3bc19a30b2f9c0596e9edad
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1745655
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | board/akemi/board.h | 1 | ||||
| -rw-r--r-- | board/akemi/gpio.inc | 2 | ||||
| -rw-r--r-- | board/hatch/board.h | 1 | ||||
| -rw-r--r-- | board/hatch/gpio.inc | 2 | ||||
| -rw-r--r-- | board/helios/board.h | 1 | ||||
| -rw-r--r-- | board/kindred/board.h | 1 | ||||
| -rw-r--r-- | board/kindred/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kohaku/board.h | 1 | ||||
| -rw-r--r-- | board/kohaku/gpio.inc | 2 |
9 files changed, 4 insertions, 9 deletions
diff --git a/board/akemi/board.h b/board/akemi/board.h index c5d6da53bf..b72fb11176 100644 --- a/board/akemi/board.h +++ b/board/akemi/board.h @@ -21,7 +21,6 @@ #define CONFIG_LOW_POWER_IDLE #define CONFIG_HOSTCMD_ESPI -/* #define CONFIG_HOSTCMD_ESPI_VW_SIGNALS */ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 diff --git a/board/akemi/gpio.inc b/board/akemi/gpio.inc index 5b7d5b9d5f..93f80a9d75 100644 --- a/board/akemi/gpio.inc +++ b/board/akemi/gpio.inc @@ -16,7 +16,7 @@ GPIO_INT(ACOK_OD, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, ex /* Power sequencing interrupts */ GPIO_INT(SLP_S0_L, PIN(D, 5), GPIO_INT_BOTH, power_signal_interrupt) -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS GPIO_INT(SLP_S3_L, PIN(A, 5), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(SLP_S4_L, PIN(D, 4), GPIO_INT_BOTH, power_signal_interrupt) #endif diff --git a/board/hatch/board.h b/board/hatch/board.h index a56b3ad7e4..73f6e59d85 100644 --- a/board/hatch/board.h +++ b/board/hatch/board.h @@ -18,7 +18,6 @@ #define CONFIG_LOW_POWER_IDLE #define CONFIG_HOSTCMD_ESPI -/* #define CONFIG_HOSTCMD_ESPI_VW_SIGNALS */ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 diff --git a/board/hatch/gpio.inc b/board/hatch/gpio.inc index 5b7d5b9d5f..93f80a9d75 100644 --- a/board/hatch/gpio.inc +++ b/board/hatch/gpio.inc @@ -16,7 +16,7 @@ GPIO_INT(ACOK_OD, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, ex /* Power sequencing interrupts */ GPIO_INT(SLP_S0_L, PIN(D, 5), GPIO_INT_BOTH, power_signal_interrupt) -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS GPIO_INT(SLP_S3_L, PIN(A, 5), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(SLP_S4_L, PIN(D, 4), GPIO_INT_BOTH, power_signal_interrupt) #endif diff --git a/board/helios/board.h b/board/helios/board.h index 13b4abc599..fcb3f5feb6 100644 --- a/board/helios/board.h +++ b/board/helios/board.h @@ -19,7 +19,6 @@ #define CONFIG_LOW_POWER_IDLE #define CONFIG_HOSTCMD_ESPI -/* #define CONFIG_HOSTCMD_ESPI_VW_SIGNALS */ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 diff --git a/board/kindred/board.h b/board/kindred/board.h index e83a556751..e0d55dc666 100644 --- a/board/kindred/board.h +++ b/board/kindred/board.h @@ -21,7 +21,6 @@ #define CONFIG_LOW_POWER_IDLE #define CONFIG_HOSTCMD_ESPI -/* #define CONFIG_HOSTCMD_ESPI_VW_SIGNALS */ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 diff --git a/board/kindred/gpio.inc b/board/kindred/gpio.inc index 2564c76888..aaa72fa91d 100644 --- a/board/kindred/gpio.inc +++ b/board/kindred/gpio.inc @@ -16,7 +16,7 @@ GPIO_INT(ACOK_OD, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, ex /* Power sequencing interrupts */ GPIO_INT(SLP_S0_L, PIN(D, 5), GPIO_INT_BOTH, power_signal_interrupt) -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS GPIO_INT(SLP_S3_L, PIN(A, 5), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(SLP_S4_L, PIN(D, 4), GPIO_INT_BOTH, power_signal_interrupt) #endif diff --git a/board/kohaku/board.h b/board/kohaku/board.h index beb23a0580..77c06266f1 100644 --- a/board/kohaku/board.h +++ b/board/kohaku/board.h @@ -18,7 +18,6 @@ #define CONFIG_LOW_POWER_IDLE #define CONFIG_HOSTCMD_ESPI -/* #define CONFIG_HOSTCMD_ESPI_VW_SIGNALS */ #undef CONFIG_UART_TX_BUF_SIZE #define CONFIG_UART_TX_BUF_SIZE 4096 diff --git a/board/kohaku/gpio.inc b/board/kohaku/gpio.inc index 6aada6f60f..8ea88cc9ce 100644 --- a/board/kohaku/gpio.inc +++ b/board/kohaku/gpio.inc @@ -16,7 +16,7 @@ GPIO_INT(ACOK_OD, PIN(0, 0), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH, ex /* Power sequencing interrupts */ GPIO_INT(SLP_S0_L, PIN(D, 5), GPIO_INT_BOTH, power_signal_interrupt) -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI_VW_SLP_SIGNALS GPIO_INT(SLP_S3_L, PIN(A, 5), GPIO_INT_BOTH, power_signal_interrupt) GPIO_INT(SLP_S4_L, PIN(D, 4), GPIO_INT_BOTH, power_signal_interrupt) #endif |