diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-12-17 09:26:33 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-19 00:12:24 +0000 |
| commit | e5935f17d1798a1f19c6003e57f140446774484f (patch) | |
| tree | 092d0227981ffad8eb951b7e29d6069174865625 | |
| parent | 616e70998d2ea08cc480baac6aa3be5964241bef (diff) | |
| download | chrome-ec-e5935f17d1798a1f19c6003e57f140446774484f.tar.gz | |
cleanup: Remove mixed-case macros
We've had uppercase macros (BOARD_FOO) for a week for
PROJECT_
BOARD_
CORE_
CHIP_
CHIP_FAMILY_
CHIP_VARIANT_
and I've just made a pass to fix the last leftover mixed-case usage
from changes that were in flight when I made the initial cleanup. It
is now time to remove the old mixed-case macros (BOARD_foo).
BUG=chromium:322144
BRANCH=none
TEST=Build all boards. Diff build/$(BOARD)/ec.RO.map before and after
this change. Should be no changes - indicating that the same code
was compiled before and after.
Change-Id: Ic5a1e83d31be4b8e9fdbacc3eb10176fd126d84a
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/180384
| -rw-r--r-- | Makefile | 2 | ||||
| -rw-r--r-- | Makefile.toolchain | 6 |
2 files changed, 3 insertions, 5 deletions
@@ -48,7 +48,7 @@ endif _tsk_cfg:=$(foreach t,$(_tsk_lst) ,HAS_TASK_$(t)) CPPFLAGS+=$(foreach t,$(_tsk_cfg),-D$(t)) _flag_cfg:=$(shell $(CPP) $(CPPFLAGS) -P -dM -Ichip/$(CHIP) -Iboard/$(BOARD) \ - include/config.h | grep -o "\#define CONFIG_[A-Za-z0-9_]*" | \ + include/config.h | grep -o "\#define CONFIG_[A-Z0-9_]*" | \ cut -c9- | sort) $(foreach c,$(_tsk_cfg) $(_flag_cfg),$(eval $(c)=y)) diff --git a/Makefile.toolchain b/Makefile.toolchain index d730c411c7..4897469a4c 100644 --- a/Makefile.toolchain +++ b/Makefile.toolchain @@ -33,10 +33,8 @@ CFLAGS_TEST=$(if $(TEST_BUILD),-DTEST_BUILD \ CFLAGS_COVERAGE=$(if $(TEST_COVERAGE),-fprofile-arcs -ftest-coverage \ -DTEST_COVERAGE,) CFLAGS_DEFINE=-DOUTDIR=$(out) -DCHIP=$(CHIP) -DBOARD_TASKFILE=ec.tasklist \ - -DBOARD=$(BOARD) -DBOARD_$(BOARD) -DCORE=$(CORE) \ - -DPROJECT=$(PROJECT) -DCHIP_$(CHIP) \ - -DCHIP_VARIANT=$(CHIP_VARIANT) -DCHIP_VARIANT_$(CHIP_VARIANT) \ - -DCHIP_FAMILY=$(CHIP_FAMILY) -DCHIP_FAMILY_$(CHIP_FAMILY) \ + -DBOARD=$(BOARD) -DCORE=$(CORE) -DPROJECT=$(PROJECT) \ + -DCHIP_VARIANT=$(CHIP_VARIANT) -DCHIP_FAMILY=$(CHIP_FAMILY) \ -DBOARD_$(UC_BOARD) -DCHIP_$(UC_CHIP) -DCORE_$(UC_CORE) \ -DCHIP_VARIANT_$(UC_CHIP_VARIANT) -DCHIP_FAMILY_$(UC_CHIP_FAMILY) CPPFLAGS=$(CFLAGS_DEFINE) $(CFLAGS_INCLUDE) $(CFLAGS_TEST) \ |