diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-01-15 19:17:54 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-21 23:55:44 +0000 |
| commit | bb958e39ae8f001b2a423fcb9d48ff8f3a7f8442 (patch) | |
| tree | babc9c6c2a3937b1824d117e662ee1c42a8ebdb0 | |
| parent | 2ee7178ac6b54c70d5ddad78c48eb7df7fcd3861 (diff) | |
| download | chrome-ec-bb958e39ae8f001b2a423fcb9d48ff8f3a7f8442.tar.gz | |
led_pwm: Cast PWM_LED_NO_CHANNEL when comparing
Without this change, sometimes the comparison to PWM_LED_NO_CHANNEL
would fail causing a panic by attempting to use a non-existent PWM
channel.
BUG=None
BRANCH=None
TEST=build and flash waddledoo, verify that EC doesn't panic anymore.
Change-Id: I0d496eaea6d7bdbc7c655796a4df12a0f9f7cf0b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2004268
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | common/led_pwm.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/common/led_pwm.c b/common/led_pwm.c index b9aeb1e805..cc946ba522 100644 --- a/common/led_pwm.c +++ b/common/led_pwm.c @@ -67,11 +67,11 @@ void set_pwm_led_color(enum pwm_led_id id, int color) duty.ch2 = led_color_map[color].ch2; } - if (led->ch0 != PWM_LED_NO_CHANNEL) + if (led->ch0 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->set_duty(led->ch0, duty.ch0); - if (led->ch1 != PWM_LED_NO_CHANNEL) + if (led->ch1 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->set_duty(led->ch1, duty.ch1); - if (led->ch2 != PWM_LED_NO_CHANNEL) + if (led->ch2 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->set_duty(led->ch2, duty.ch2); } @@ -98,11 +98,11 @@ static void set_pwm_led_enable(enum pwm_led_id id, int enable) if ((id >= CONFIG_LED_PWM_COUNT) || (id < 0)) return; - if (led->ch0 != PWM_LED_NO_CHANNEL) + if (led->ch0 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->enable(led->ch0, enable); - if (led->ch1 != PWM_LED_NO_CHANNEL) + if (led->ch1 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->enable(led->ch1, enable); - if (led->ch2 != PWM_LED_NO_CHANNEL) + if (led->ch2 != (enum pwm_channel)PWM_LED_NO_CHANNEL) led->enable(led->ch2, enable); } |