summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@chromium.org>2018-03-19 10:12:32 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-05-16 05:08:30 -0700
commit9be407f10ed2710a4a29a94ef96f6a6c97a2f2a1 (patch)
tree0d1cf542bbb6ade6fa23d961615136826e2c05e3
parentf139d3a0ca9215b5b5bb2abc1f120ff6171036c9 (diff)
downloadchrome-ec-9be407f10ed2710a4a29a94ef96f6a6c97a2f2a1.tar.gz
chip/npcx: Increase default stack size for tasks
Usually, we enable CONFIG_FPU on NPCX, which requires larger stack size. Also, NPCX has very deep call patch in I2C transactions (in particular, I2C recovery path), so it generally requires larger stack. To make the code fit, however, we need to reduce the accelerometer fifo depth from 1024 to 512, on a few boards. BRANCH=none BUG=b:75234824 TEST=make buildall -j, stackanalyzer result on poppy looks a little better. Change-Id: I37b5a2a97a760dc4fd225253c23962d74e25605a Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/967963 Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
-rw-r--r--board/coral/board.h2
-rw-r--r--board/eve/board.h2
-rw-r--r--board/kahlee/board.h2
-rw-r--r--board/kevin/board.h2
-rw-r--r--board/nami/board.h2
-rw-r--r--board/reef/board.h2
-rw-r--r--chip/npcx/config_chip.h14
7 files changed, 13 insertions, 13 deletions
diff --git a/board/coral/board.h b/board/coral/board.h
index d063e6131f..484b83949d 100644
--- a/board/coral/board.h
+++ b/board/coral/board.h
@@ -206,7 +206,7 @@
#define CONFIG_DYNAMIC_MOTION_SENSOR_COUNT
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 1024
+#define CONFIG_ACCEL_FIFO 512
/* Depends on how fast the AP boots and typical ODRs */
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
diff --git a/board/eve/board.h b/board/eve/board.h
index 727986e7c1..b9d0531a3b 100644
--- a/board/eve/board.h
+++ b/board/eve/board.h
@@ -135,7 +135,7 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 1024
+#define CONFIG_ACCEL_FIFO 512
/* Depends on how fast the AP boots and typical ODRs */
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
diff --git a/board/kahlee/board.h b/board/kahlee/board.h
index d77b89bb29..ac9745ce3c 100644
--- a/board/kahlee/board.h
+++ b/board/kahlee/board.h
@@ -178,7 +178,7 @@
#undef CONFIG_LID_ANGLE_SENSOR_LID
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 1024
+#define CONFIG_ACCEL_FIFO 512
/* Depends on how fast the AP boots and typical ODRs */
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
diff --git a/board/kevin/board.h b/board/kevin/board.h
index d249ed3764..152c7890ba 100644
--- a/board/kevin/board.h
+++ b/board/kevin/board.h
@@ -101,7 +101,7 @@
#define CONFIG_BARO_BMP280
#endif
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 256
+#define CONFIG_ACCEL_FIFO 128
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
/* Sensors without hardware FIFO are in forced mode */
diff --git a/board/nami/board.h b/board/nami/board.h
index 2f329e5e42..1651a32d04 100644
--- a/board/nami/board.h
+++ b/board/nami/board.h
@@ -134,7 +134,7 @@
#define CONFIG_LED_DRIVER_LM3509
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 1024
+#define CONFIG_ACCEL_FIFO 512
/* Depends on how fast the AP boots and typical ODRs */
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
diff --git a/board/reef/board.h b/board/reef/board.h
index a3060be05f..a1b45ddf08 100644
--- a/board/reef/board.h
+++ b/board/reef/board.h
@@ -205,7 +205,7 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* FIFO size is in power of 2. */
-#define CONFIG_ACCEL_FIFO 1024
+#define CONFIG_ACCEL_FIFO 512
/* Depends on how fast the AP boots and typical ODRs */
#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3)
diff --git a/chip/npcx/config_chip.h b/chip/npcx/config_chip.h
index b9348cea42..1311edca4f 100644
--- a/chip/npcx/config_chip.h
+++ b/chip/npcx/config_chip.h
@@ -39,16 +39,16 @@
#define CONFIG_STACK_SIZE 1024
/* non-standard task stack sizes */
-#define IDLE_TASK_STACK_SIZE 512
-#define LARGER_TASK_STACK_SIZE 640
-#define VENTI_TASK_STACK_SIZE 768
+#define IDLE_TASK_STACK_SIZE 672
+#define LARGER_TASK_STACK_SIZE 800
+#define VENTI_TASK_STACK_SIZE 928
-#define CHARGER_TASK_STACK_SIZE 640
-#define HOOKS_TASK_STACK_SIZE 640
-#define CONSOLE_TASK_STACK_SIZE 640
+#define CHARGER_TASK_STACK_SIZE 800
+#define HOOKS_TASK_STACK_SIZE 800
+#define CONSOLE_TASK_STACK_SIZE 800
/* Default task stack size */
-#define TASK_STACK_SIZE 512
+#define TASK_STACK_SIZE 672
/* Address of RAM log used by Booter */
#define ADDR_BOOT_RAMLOG 0x100C7FC0