summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward Hill <ecgh@chromium.org>2020-02-21 10:20:19 -0700
committerCommit Bot <commit-bot@chromium.org>2020-02-27 05:29:09 +0000
commitdd7b4c1eabd03000d0cb06f872f9b43393494ee7 (patch)
tree9fd8a6ad676412395bb7ad571974c415ff54e294
parent29918a71d3622f9c9da9a4db37bb1843ce8f3284 (diff)
downloadchrome-ec-dd7b4c1eabd03000d0cb06f872f9b43393494ee7.tar.gz
tcpmv2: Clean up TC_UNATTACHED
CL 1900058 reverted CL 1825504 (remove unnecessary tcpc CC reads) and (unintentionally?) removed the TC_UNATTACHED super state added by CL 1864427. This change removes the now unused TC_UNATTACHED super state from enum usb_tc_state and cleans up comments to match the code. BUG=none BRANCH=none TEST=none Change-Id: Ia254208edd84e92cc8d8c13469f90c4f1e02fe1f Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068528 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org>
-rw-r--r--common/usbc/usb_tc_drp_acc_trysrc_sm.c12
1 files changed, 1 insertions, 11 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c
index 30015acc71..4a14ee8b25 100644
--- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c
+++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c
@@ -147,7 +147,6 @@ enum usb_tc_state {
TC_CC_OPEN,
TC_CC_RD,
TC_CC_RP,
- TC_UNATTACHED,
};
/* Forward declare the full list of states. This is indexed by usb_tc_state */
static const struct usb_state tc_states[];
@@ -1618,8 +1617,6 @@ static void tc_error_recovery_run(const int port)
/**
* Unattached.SNK
- *
- * Super State is Unattached state
*/
static void tc_unattached_snk_entry(const int port)
{
@@ -2302,8 +2299,6 @@ static void tc_dbg_acc_snk_exit(const int port)
/**
* Unattached.SRC
- *
- * Super State is Unattached state
*/
static void tc_unattached_src_entry(const int port)
{
@@ -3271,14 +3266,9 @@ DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, pd_chipset_shutdown, HOOK_PRIO_DEFAULT);
/*
* Type-C State Hierarchy (Sub-States are listed inside the boxes)
*
- * |TC_UNATTACHED ---------|
- * | |
- * | TC_UNATTACHED_SNK |
- * | TC_UNATTACHED_SRC |
- * |-----------------------|
- *
* |TC_CC_RD --------------| |TC_CC_RP ------------------------|
* | | | |
+ * | TC_UNATTACHED_SNK | | TC_UNATTACHED_SRC |
* | TC_ATTACH_WAIT_SNK | | TC_ATTACH_WAIT_SRC |
* | TC_TRY_WAIT_SNK | | TC_TRY_SRC |
* | TC_DBG_ACC_SNK | | TC_UNORIENTED_DBG_ACC_SRC |