diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2020-03-18 13:37:36 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-20 15:29:09 +0000 |
| commit | 0c7bcb0bdba243127dbb6592f94961bd39e48a97 (patch) | |
| tree | 0f2cdad0ff824715cd7edff61efd7c519d76ba6c | |
| parent | 47819d2b59598b30f49ca8a76d7477641da638f2 (diff) | |
| download | chrome-ec-0c7bcb0bdba243127dbb6592f94961bd39e48a97.tar.gz | |
code_reviews: Add an example of CLs linked by topic
BUG=none
TEST=View rendered Markdown
BRANCH=none
Change-Id: Icabde60da7758d89ab11abe11d5870f25fda4209
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108862
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | docs/code_reviews.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/docs/code_reviews.md b/docs/code_reviews.md index 2abe2cad27..45bbb36095 100644 --- a/docs/code_reviews.md +++ b/docs/code_reviews.md @@ -86,7 +86,8 @@ Add your name to the [list of reviewers][1]. * Prioritize reviewers who may want fundamental changes, e.g. a component maintainer or domain expert should look at it before a language expert. * Keep related changes in a single relation chain if practical. - * If not, consider using [topics][2] in Gerrit to group related CLs. + * If not, consider using [topics][2] in Gerrit to group related CLs. For + example, the topic ["CBI PCB supplier field"][6] links multiple CLs. * Try to make visible updates actionable for reviewers. * Don’t post a comment saying that you’ve done something before the patchset that does it. @@ -145,3 +146,4 @@ Add your name to the [list of reviewers][1]. [3]: https://doc.coreboot.org/getting_started/gerrit_guidelines.html [4]: https://g3doc.corp.google.com/gws/tools/gwsq/v3/g3doc/gerrit.md [5]: https://google.github.io/eng-practices/review/developer/small-cls.html +[6]: https://chromium-review.googlesource.com/q/topic:%2522CBI+PCB+supplier+field%2522 |