diff options
| author | Wai-Hong Tam <waihong@google.com> | 2020-04-20 15:35:00 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-22 00:51:53 +0000 |
| commit | a3541ae7d490b84a38aa9079a1644509961dc6e0 (patch) | |
| tree | f4564350e33f658e6f475d78a8ec285c3de5af52 | |
| parent | bf4e772a95951ecbcc8c10d9d643473cd6fa0336 (diff) | |
| download | chrome-ec-a3541ae7d490b84a38aa9079a1644509961dc6e0.tar.gz | |
Trogdor: Increase the delay between power-on the system and power-on the PMIC
This is about the delay between power-on the system (switchcap) and
power-on the PMIC. Some latest PMIC firmware needs this delay longer,
when doing a cold reboot. Did an experiment; it should be 100ms+.
BRANCH=None
BUG=b:152936484, b:148478165
TEST=Did quick power off and on for 100 iterations, S0->S5->S0, like:
$ dut-control ec_uart_cmd:'power off' sleep:0.1 ec_uart_cmd:'power on'
TEST=Toggled warm_reset for 100 iterations, like:
$ dut-control warm_reset:on sleep:0.2 warm_reset:off
Change-Id: I0e7287011620a2e065655a46d6358f0cc1d5e03a
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2159625
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
| -rw-r--r-- | power/sc7180.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/power/sc7180.c b/power/sc7180.c index 046c88d7b0..0d2412b095 100644 --- a/power/sc7180.c +++ b/power/sc7180.c @@ -84,8 +84,12 @@ /* Wait for polling if the switchcap outputs good voltage */ #define SWITCHCAP_PG_CHECK_WAIT (5 * MSEC) -/* Delay between power-on the system and power-on the PMIC */ -#define SYSTEM_POWER_ON_DELAY (10 * MSEC) +/* + * Delay between power-on the system and power-on the PMIC. + * Some latest PMIC firmware needs this delay longer, for doing a cold + * reboot. Did an experiment; it should be 100ms+. Set it with margin. + */ +#define SYSTEM_POWER_ON_DELAY (110 * MSEC) /* TODO(crosbug.com/p/25047): move to HOOK_POWER_BUTTON_CHANGE */ /* 1 if the power button was pressed last time we checked */ |