diff options
| author | Lu Zhang <lu.zhang@bitland.corp-partner.google.com> | 2020-04-26 21:40:18 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-27 04:13:52 +0000 |
| commit | ff10b3a10baa4e47defccdd825b8a6f9d808e3b6 (patch) | |
| tree | 1d2bc30ba13fcb9c53f76ef81943dcaae4149a1e | |
| parent | 486d49750715c5ca5ff279b04e3f9b95fc8541d3 (diff) | |
| download | chrome-ec-ff10b3a10baa4e47defccdd825b8a6f9d808e3b6.tar.gz | |
ioexpander: set GPIO only when real set
Ioexpander shouldn't change the GPIO level when EC doesn't set
GPIO_HIGH or GPIO_LOW.
BUG=b:154447176
BRANCH=none
TEST=use ioexget command to see if this GPIO changes when jump rw.
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: Id49612557441036df574ebef961beb3ba1879aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167114
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
| -rw-r--r-- | driver/ioexpander/pcal6408.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/ioexpander/pcal6408.c b/driver/ioexpander/pcal6408.c index 7b44e1fb71..27fbacca70 100644 --- a/driver/ioexpander/pcal6408.c +++ b/driver/ioexpander/pcal6408.c @@ -218,7 +218,7 @@ static int pcal6408_ioex_set_flags_by_mask(int ioex, int port, int mask, if (flags & GPIO_HIGH) val |= mask; - else + else if (flags & GPIO_LOW) val &= ~mask; rv = pcal6408_write(ioex, PCAL6408_REG_OUTPUT, val); |