diff options
| author | Andrew McRae <amcrae@google.com> | 2020-06-25 12:33:49 +1000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-25 06:37:31 +0000 |
| commit | 8625c8d66202d62a9c68fdba2a8bfbc49d05e9cf (patch) | |
| tree | 7bf26253b574d55017741f320139d220f9042768 | |
| parent | 1620833b5e7c97a1f0d2a7007746e1f961d7587f (diff) | |
| download | chrome-ec-8625c8d66202d62a9c68fdba2a8bfbc49d05e9cf.tar.gz | |
TCPMv2: Add some TODO bugs, fix indent
Add some TODO bugs, fix indents.
BUG=b:159073520
TEST=Build all
BRANCH=none
Change-Id: Ic06450e50924bdcedd12829ba683cc6b3b308ae0
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2264693
Tested-by: Andrew McRae <amcrae@chromium.org>
Auto-Submit: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | common/usb_pd_alt_mode_dfp.c | 2 | ||||
| -rw-r--r-- | common/usbc/dp_alt_mode.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/common/usb_pd_alt_mode_dfp.c b/common/usb_pd_alt_mode_dfp.c index 233fb4ea0f..cb34c547fb 100644 --- a/common/usb_pd_alt_mode_dfp.c +++ b/common/usb_pd_alt_mode_dfp.c @@ -248,7 +248,7 @@ uint32_t pd_dfp_enter_mode(int port, enum tcpm_transmit_type type, /* * Strictly speaking, this should only happen when the request * has been ACKed. - * TODO: Redo setting the enter mode flag to incorporate + * TODO(b/159854667): Redo setting the enter mode flag to incorporate * it into the DP state machine. */ pd_set_dfp_enter_mode_flag(port, true); diff --git a/common/usbc/dp_alt_mode.c b/common/usbc/dp_alt_mode.c index 4888383c9d..0ae4d858dd 100644 --- a/common/usbc/dp_alt_mode.c +++ b/common/usbc/dp_alt_mode.c @@ -87,10 +87,10 @@ static bool dp_response_valid(int port, enum tcpm_transmit_type type, */ if (type != TCPC_TX_SOP || (st != DP_INACTIVE && state_vdm_cmd[st] != vdm_cmd)) { - CPRINTS("C%d: Received unexpected DP VDM %s (cmd %d) from" " %s in state %d", port, cmdt, vdm_cmd, - type == TCPC_TX_SOP ? "port partner" : "cable plug", st); + type == TCPC_TX_SOP ? "port partner" : "cable plug", + st); dp_entry_failed(port); return false; } @@ -250,7 +250,7 @@ int dp_setup_next_vdm(int port, int vdo_count, uint32_t *vdm) * into recovery mode) while DP alt mode is active. * It would be good to invoke modep->fx->exit but * this doesn't set up the VDM, it clears state. - * TODO: Clean up the API to the fx functions. + * TODO(b/159856063): Clean up the API to the fx functions. */ if (!(modep && modep->opos)) return -1; |