diff options
| author | Caveh Jalali <caveh@chromium.org> | 2020-06-23 23:37:34 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-25 00:16:46 +0000 |
| commit | e85344ba1dc78fe31d4b0804fd81fede86bc705c (patch) | |
| tree | 347d8169d443c554b5cd8b0a9604802842d66782 | |
| parent | 7c3980117e84cf3557a909806bddb376dfb74817 (diff) | |
| download | chrome-ec-e85344ba1dc78fe31d4b0804fd81fede86bc705c.tar.gz | |
volteer: reset the TCPCs on EC reset
this fixes the ps8815 not being taken out of reset due to EFS2
interactions.
when EFS2 is enabled, we sysjump to RW very early - before INIT_HOOKS
run. any code in INIT_HOOK functions that is predicated by
system_jumped_to_this_image() will either always run or never
run. this is not the intended behavior.
the solution is to use system_jumped_late() instead.
BRANCH=none
BUG=b:159769490
TEST=ps8815 no longer stays in reset after EFS2 sysjump
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: I6c2048f5caad8eb790dab8a5b44fc55da92baa48
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2263092
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | baseboard/volteer/baseboard.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/baseboard/volteer/baseboard.c b/baseboard/volteer/baseboard.c index 1c4f7cb7b7..1586c759f6 100644 --- a/baseboard/volteer/baseboard.c +++ b/baseboard/volteer/baseboard.c @@ -354,8 +354,8 @@ BUILD_ASSERT(ARRAY_SIZE(bb_controls) == USBC_PORT_COUNT); static void baseboard_tcpc_init(void) { - /* Only reset TCPC if not sysjump */ - if (!system_jumped_to_this_image()) + /* Don't reset TCPCs after initial reset */ + if (!system_jumped_late()) board_reset_pd_mcu(); /* Enable PPC interrupts. */ |