diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2020-11-04 17:19:21 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-11-06 03:07:01 +0000 |
| commit | e541093661124cd63d3ef9ca1877676311df9861 (patch) | |
| tree | 85f56e807b1badfc3b2bccd0c78d918c997f75a3 | |
| parent | b824f8ca4df75518669f2f6e3e8b6b3b017765df (diff) | |
| download | chrome-ec-e541093661124cd63d3ef9ca1877676311df9861.tar.gz | |
Revert "motion_sense: set sensor data rate to 0, when sensors are being powered off"
We can not change the ODR when the sensors are marked as not active.
They may not be powered on and can not be touched.
This reverts commit 89b87b5004252bd6f6fa6c019a63a4a1dd157600.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> motion_sense: set sensor data rate to 0, when sensors are being powered off
>
> when sensors are being powered off, we should set sensor data rate to 0,
> to prevent the motion sense task from being unable to enter the idle
> state because the collect rate is not equal to 0.
>
> BUG=b:170703322
> BRANCH=master
> TEST=make buildall pass, and test cerise power consumption meet spec in
> DC S5 state
>
> Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
> Change-Id: Iae66f87aee1889b460fd598b1962be658c74ddab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2505392
> Reviewed-by: Cheng-Hao Yang <chenghaoyang@chromium.org>
> Reviewed-by: Ting Shen <phoenixshen@chromium.org>
BRANCH=master
BUG=b:170703322
TEST=compile
Change-Id: Ieb8566614249fc2efdce5993291ceb98bab429f8
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519428
| -rw-r--r-- | common/motion_sense.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/common/motion_sense.c b/common/motion_sense.c index b2a7162962..e31ec5eddc 100644 --- a/common/motion_sense.c +++ b/common/motion_sense.c @@ -390,10 +390,8 @@ static void motion_sense_switch_sensor_rate(void) } } else { /* The sensors are being powered off */ - if (sensor->state == SENSOR_INITIALIZED) { - sensor->drv->set_data_rate(sensor, 0, 0); + if (sensor->state == SENSOR_INITIALIZED) sensor->state = SENSOR_NOT_INITIALIZED; - } } } motion_sense_set_motion_intervals(); |