summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbe Levkoy <alevkoy@chromium.org>2020-09-17 15:11:15 -0600
committerCommit Bot <commit-bot@chromium.org>2020-09-18 19:07:36 +0000
commit6ed9b65ae38977118f0d5f02d6f5c61da23c5f24 (patch)
tree1218414fc433747824058239b3ce7efa8ee382d8
parent6f137ef733489c4de18d0d72b6015c97ef71c848 (diff)
downloadchrome-ec-6ed9b65ae38977118f0d5f02d6f5c61da23c5f24.tar.gz
volteer: Move USB PID to board files
Add TODOs to update variants boards. BUG=none TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If0d8d0dd544c06114f355dcf281b2841a8397aee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417348 Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat
-rw-r--r--baseboard/volteer/baseboard.h7
-rw-r--r--board/delbin/board.h2
-rw-r--r--board/eldrid/board.h2
-rw-r--r--board/halvor/board.h2
-rw-r--r--board/lindar/board.h2
-rw-r--r--board/lingcod/board.h2
-rw-r--r--board/malefor/board.h2
-rw-r--r--board/terrador/board.h2
-rw-r--r--board/todor/board.h2
-rw-r--r--board/trondo/board.h2
-rw-r--r--board/volteer/board.h7
-rw-r--r--board/voxel/board.h2
12 files changed, 27 insertions, 7 deletions
diff --git a/baseboard/volteer/baseboard.h b/baseboard/volteer/baseboard.h
index 024b1d521b..b4d0645e3b 100644
--- a/baseboard/volteer/baseboard.h
+++ b/baseboard/volteer/baseboard.h
@@ -214,13 +214,6 @@
/* UART COMMAND */
#define CONFIG_CMD_CHARGEN
-/*
- * USB ID
- * This is allocated specifically for Volteer
- * http://google3/hardware/standards/usb/
- */
-#define CONFIG_USB_PID 0x503E
-
/* Retimer */
#define CONFIG_USBC_RETIMER_INTEL_BB
#define CONFIG_USBC_RETIMER_INTEL_BB_RUNTIME_CONFIG
diff --git a/board/delbin/board.h b/board/delbin/board.h
index 7b94edf039..a2b80aad0c 100644
--- a/board/delbin/board.h
+++ b/board/delbin/board.h
@@ -53,6 +53,8 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/* TODO(b/168827128): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/eldrid/board.h b/board/eldrid/board.h
index 0e8d754182..a127a8e272 100644
--- a/board/eldrid/board.h
+++ b/board/eldrid/board.h
@@ -64,6 +64,8 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/* TODO(b/168826914): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/halvor/board.h b/board/halvor/board.h
index b1db5627fa..6d01d8faf0 100644
--- a/board/halvor/board.h
+++ b/board/halvor/board.h
@@ -42,6 +42,8 @@
(BIT(LID_ACCEL) | BIT(CLEAR_ALS))
/* USB Type C and USB PD defines */
+/* TODO(b/168826868): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 3
/*
diff --git a/board/lindar/board.h b/board/lindar/board.h
index e749275e26..d8d05492e5 100644
--- a/board/lindar/board.h
+++ b/board/lindar/board.h
@@ -31,6 +31,8 @@
#undef CONFIG_MKBP_EVENT
/* USB Type C and USB PD defines */
+/* TODO(b/168827029): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/lingcod/board.h b/board/lingcod/board.h
index 230b40fd84..bf89a8a240 100644
--- a/board/lingcod/board.h
+++ b/board/lingcod/board.h
@@ -43,6 +43,8 @@
TASK_EVENT_MOTION_SENSOR_INTERRUPT(BASE_ACCEL)
/* USB Type C and USB PD defines */
+/* TODO(b/168827133): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/malefor/board.h b/board/malefor/board.h
index 321fbc130f..8d4e01e513 100644
--- a/board/malefor/board.h
+++ b/board/malefor/board.h
@@ -43,6 +43,8 @@
TASK_EVENT_MOTION_SENSOR_INTERRUPT(BASE_ACCEL)
/* USB Type C and USB PD defines */
+/* TODO(b/168826886): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/terrador/board.h b/board/terrador/board.h
index 16c72663de..15924ab5e1 100644
--- a/board/terrador/board.h
+++ b/board/terrador/board.h
@@ -54,6 +54,8 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/* TODO(b/168827418): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/todor/board.h b/board/todor/board.h
index 011fd8e359..d275869855 100644
--- a/board/todor/board.h
+++ b/board/todor/board.h
@@ -54,6 +54,8 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/* TODO(b/168827570): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/trondo/board.h b/board/trondo/board.h
index c81bc1a5db..7b87088711 100644
--- a/board/trondo/board.h
+++ b/board/trondo/board.h
@@ -47,6 +47,8 @@
(BIT(LID_ACCEL) | BIT(CLEAR_ALS))
/* USB Type C and USB PD defines */
+/* TODO(b/168826898): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/volteer/board.h b/board/volteer/board.h
index 4aa02f6d6b..793bb1a1a4 100644
--- a/board/volteer/board.h
+++ b/board/volteer/board.h
@@ -72,6 +72,13 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/*
+ * USB ID
+ * This is allocated specifically for Volteer
+ * http://google3/hardware/standards/usb/
+ */
+#define CONFIG_USB_PID 0x503E
+
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
diff --git a/board/voxel/board.h b/board/voxel/board.h
index c9b2d8948f..0bd807aeda 100644
--- a/board/voxel/board.h
+++ b/board/voxel/board.h
@@ -54,6 +54,8 @@
#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL
/* USB Type C and USB PD defines */
+/* TODO(b/168826898): Don't use Volteer PID. */
+#define CONFIG_USB_PID 0x503E
#define CONFIG_USB_PD_PORT_MAX_COUNT 2
/*
View Lorry Controller Status