diff options
| author | Caveh Jalali <caveh@chromium.org> | 2021-02-22 18:35:36 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-02-24 00:11:51 +0000 |
| commit | 47174f35e65badc908d1aa6f09f5d0dd566a9ab0 (patch) | |
| tree | c3410215f52d0a36efaf0e961872e9287e797674 | |
| parent | cbcc6536d54c8f9d9a7a74a7766d39c00bfeb477 (diff) | |
| download | chrome-ec-47174f35e65badc908d1aa6f09f5d0dd566a9ab0.tar.gz | |
brya: Update keyboard KSO02 pin definition
This updates the keyboard pin definitions. KSI02 is used in GPIO mode
(i.e. ALTERNATE function), however the NPCX support code automatically
puts all pins declared as GPIO into GPIO mode. No explicit ALTERNATE pin
declaration is needed.
Nuvoton support code interprets ALTERNATE declarations as a request for
a pin to be configured as a function other than GPIO, regardless of
whether the pin's primary or secondary function is GPIO. This put KSO02
into ALTERNATE (i.e. keyboard) mode when it actually needs to be in GPIO
mode.
BRANCH=none
BUG=b:180759360
TEST=all keyboard keys respond on brya
Change-Id: I15221eafde1682bae527bea8fe14280c78bb489b
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2713938
Reviewed-by: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | board/brya/generated-gpio.inc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/board/brya/generated-gpio.inc b/board/brya/generated-gpio.inc index db8b5cb35d..222905a05d 100644 --- a/board/brya/generated-gpio.inc +++ b/board/brya/generated-gpio.inc @@ -107,7 +107,6 @@ ALTERNATE(PIN_MASK(4, 0x34), 0, MODULE_ADC, 0) /* GPIO42/ADC3/RI_L /* KB alternate functions */ ALTERNATE(PIN_MASK(0, 0xf0), 0, MODULE_KB, GPIO_ODR_HIGH) /* KSO10&P80_CLK/GPIO07, KSO11&P80_DAT/GPIO06, KSO12/GPIO05, KSO13/GPIO04 */ ALTERNATE(PIN_MASK(1, 0x7f), 0, MODULE_KB, GPIO_ODR_HIGH) /* KSO06/GPO13/GP_SEL_L, KSO07/GPO12/JEN_L, KSO03/GPIO16/JTAG_TDO0_SWO, KSO04/GPIO15/XNOR, KSO05/GPIO14, KSO08/GPIO11/CR_SOUT1, KSO09/GPIO10/CR_SIN1 */ -ALTERNATE(PIN_MASK(1, 0x80), 0, MODULE_KB, GPIO_OUT_LOW) /* KSO02/GPIO17/JTAG_TDI */ ALTERNATE(PIN_MASK(2, 0xfc), 0, MODULE_KB, GPIO_INPUT | GPIO_PULL_UP) /* KSI2/GPIO27/TRACEDATA1, KSI3/GPIO26/TRACEDATA0, KSI4/GPIO25/TRACECLK/GP_SCLK, KSI5/GPIO24/GP_MISO, KSI6/GPIO23/S_SBUB, KSI7/GPIO22/S_SBUA */ ALTERNATE(PIN_MASK(2, 0x03), 0, MODULE_KB, GPIO_ODR_HIGH) /* KSO00/GPIO21/JTAG_TCK_SWCLK, KSO01/GPIO20/JTAG_TMS_SWIO */ ALTERNATE(PIN_MASK(3, 0x03), 0, MODULE_KB, GPIO_INPUT | GPIO_PULL_UP) /* KSI0/GPIO31/TRACEDATA3/GP_MOSI, KSI1/GPIO30/TRACEDATA2/GP_CS_L */ |