diff options
| author | Wai-Hong Tam <waihong@google.com> | 2021-06-09 11:23:14 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-06-09 22:08:02 +0000 |
| commit | bd2c57278e3a3c6b351c6aaccc5907d7a6de56cb (patch) | |
| tree | 9b53fcb4cd19257c54b28da8ee4a12c457caa1a4 | |
| parent | b405c16d3362cf9e213aadef23247239b3f35ff5 (diff) | |
| download | chrome-ec-bd2c57278e3a3c6b351c6aaccc5907d7a6de56cb.tar.gz | |
trogdor: Change GPIO HIBERNATE_L to open drain
We stuffed an external pull-up resistor on the GPIO HIBERNATE_L for
fixing the CCD bugs, like b/173828265, b/177611071.
The GPIO can be used as open drain.
BRANCH=Trogdor
BUG=b:189184814
TEST=Tested on Lazor; CCD connection still worked under EC hibernate.
Change-Id: I50d832f1619f976a4cb682fa1b666add96563222
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2950925
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| -rw-r--r-- | board/coachz/gpio.inc | 2 | ||||
| -rw-r--r-- | board/homestar/gpio.inc | 4 | ||||
| -rw-r--r-- | board/lazor/gpio.inc | 2 | ||||
| -rw-r--r-- | board/marzipan/gpio.inc | 2 | ||||
| -rw-r--r-- | board/pompom/gpio.inc | 2 | ||||
| -rw-r--r-- | board/trogdor/gpio.inc | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/board/coachz/gpio.inc b/board/coachz/gpio.inc index e84c690f55..8f5f1498a1 100644 --- a/board/coachz/gpio.inc +++ b/board/coachz/gpio.inc @@ -65,7 +65,7 @@ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ GPIO(SWITCHCAP_ON, PIN(D, 5), GPIO_OUT_LOW) /* Enable switch cap; will be configured in the board init */ GPIO(EN_PP3300_A, PIN(A, 6), GPIO_OUT_LOW) /* Enable PP3300 */ GPIO(EN_PP5000_A, PIN(6, 7), GPIO_OUT_LOW) /* Enable PP5000 */ diff --git a/board/homestar/gpio.inc b/board/homestar/gpio.inc index 165968d48c..714c640a53 100644 --- a/board/homestar/gpio.inc +++ b/board/homestar/gpio.inc @@ -62,8 +62,8 @@ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ -GPIO(SWITCHCAP_ON_L, PIN(D, 5), GPIO_ODR_HIGH) /* Enable switch cap */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ +GPIO(SWITCHCAP_ON_L, PIN(D, 5), GPIO_ODR_HIGH) /* Enable switch cap */ GPIO(EN_PP3300_A, PIN(A, 6), GPIO_OUT_LOW) /* Enable PP3300 */ GPIO(EN_PP5000_A, PIN(6, 7), GPIO_OUT_LOW) /* Enable PP5000 */ GPIO(EC_BL_DISABLE_L, PIN(B, 6), GPIO_OUT_LOW) /* Backlight disable signal from EC */ diff --git a/board/lazor/gpio.inc b/board/lazor/gpio.inc index 76447bf32a..b5c15b3729 100644 --- a/board/lazor/gpio.inc +++ b/board/lazor/gpio.inc @@ -65,7 +65,7 @@ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ GPIO(SWITCHCAP_ON, PIN(D, 5), GPIO_OUT_LOW) /* Enable switch cap; will be configured in the board init */ /* TODO(waihong): Remove it. The VBOB switch is for backup. */ GPIO(VBOB_EN, PIN(D, 3), GPIO_OUT_LOW) /* Enable VBOB */ diff --git a/board/marzipan/gpio.inc b/board/marzipan/gpio.inc index be69f4f509..11fa6b5a53 100644 --- a/board/marzipan/gpio.inc +++ b/board/marzipan/gpio.inc @@ -57,7 +57,7 @@ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ GPIO(SWITCHCAP_ON, PIN(D, 5), GPIO_OUT_LOW) /* Enable switch cap; will be configured in the board init */ GPIO(EN_PP3300_A, PIN(A, 6), GPIO_OUT_LOW) /* Enable PP3300 */ GPIO(EN_PP5000_A, PIN(6, 7), GPIO_OUT_LOW) /* Enable PP5000 */ diff --git a/board/pompom/gpio.inc b/board/pompom/gpio.inc index 1a7492582f..531452eae3 100644 --- a/board/pompom/gpio.inc +++ b/board/pompom/gpio.inc @@ -55,7 +55,7 @@ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between GPIO(QSIP_ON, PIN(5, 0), GPIO_OUT_LOW) /* Not used, for non-switchcap testing */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ GPIO(SWITCHCAP_ON, PIN(D, 5), GPIO_OUT_LOW) /* Enable switch cap */ GPIO(EN_PP3300_A, PIN(A, 6), GPIO_OUT_LOW) /* Enable PP3300 */ GPIO(EN_PP5000_A, PIN(6, 7), GPIO_OUT_LOW) /* Enable PP5000 */ diff --git a/board/trogdor/gpio.inc b/board/trogdor/gpio.inc index bfa604c240..687b98ee06 100644 --- a/board/trogdor/gpio.inc +++ b/board/trogdor/gpio.inc @@ -62,7 +62,7 @@ GPIO(PMIC_KPD_PWR_ODL, PIN(D, 6), GPIO_ODR_HIGH) /* PMIC power button */ GPIO(EC_INT_L, PIN(A, 2), GPIO_ODR_HIGH) /* Interrupt line between AP and EC */ /* Power enables */ -GPIO(HIBERNATE_L, PIN(5, 2), GPIO_OUT_HIGH) /* EC hibernate */ +GPIO(HIBERNATE_L, PIN(5, 2), GPIO_ODR_HIGH) /* EC hibernate */ GPIO(SWITCHCAP_ON, PIN(D, 5), GPIO_OUT_LOW) /* Enable switch cap */ GPIO(EN_PP3300_A, PIN(A, 6), GPIO_OUT_LOW) /* Enable PP3300 */ GPIO(EN_PP5000_A, PIN(6, 7), GPIO_OUT_LOW) /* Enable PP5000 */ |