summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVijay Hiremath <vijay.p.hiremath@intel.com>2021-07-13 12:10:20 -0700
committerCommit Bot <commit-bot@chromium.org>2021-07-14 05:56:49 +0000
commit8402804abbf3e6c16a01f0dd1cd239a84bcaef3b (patch)
tree6dbad4054375814f3b42aebb2752dbe6b2dffed0
parent638520a30b8206ae58a082cc1bda4a135c756df1 (diff)
downloadchrome-ec-8402804abbf3e6c16a01f0dd1cd239a84bcaef3b.tar.gz
adlrvp: Add custom board ID reading function
ADLRVP has a I/O expander + EEPROM based board ID reading implementation hence added overridable custom board ID reading function. BUG=none BRANCH=none TEST='ectool version' gives intended result Change-Id: I98e49de710f54683b8fbe9f6e9615b7de0aeb4ed Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3024669 Reviewed-by: AndreX Andraos <andrex.andraos@intel.com> Reviewed-by: caveh jalali <caveh@chromium.org>
-rw-r--r--baseboard/intelrvp/adlrvp.c2
-rw-r--r--baseboard/intelrvp/adlrvp.h1
-rw-r--r--baseboard/intelrvp/adlrvp_ioex_gpio.inc5
3 files changed, 7 insertions, 1 deletions
diff --git a/baseboard/intelrvp/adlrvp.c b/baseboard/intelrvp/adlrvp.c
index d7840fd9f4..ad7066fe5d 100644
--- a/baseboard/intelrvp/adlrvp.c
+++ b/baseboard/intelrvp/adlrvp.c
@@ -376,7 +376,7 @@ const int pwrok_signal_deassert_count = ARRAY_SIZE(pwrok_signal_assert_list);
* Returns board information (board id[7:0] and Fab id[15:8]) on success
* -1 on error.
*/
-int board_get_version(void)
+__override int board_get_version(void)
{
/* Cache the ADLRVP board ID */
static int adlrvp_board_id;
diff --git a/baseboard/intelrvp/adlrvp.h b/baseboard/intelrvp/adlrvp.h
index a8adcdff19..83c441b46d 100644
--- a/baseboard/intelrvp/adlrvp.h
+++ b/baseboard/intelrvp/adlrvp.h
@@ -14,6 +14,7 @@
#include "baseboard.h"
/* RVP Board ids */
+#define CONFIG_BOARD_VERSION_GPIO
#define ADLP_DDR5_RVP_SKU_BOARD_ID 0x12
#define ADLP_LP5_T4_RVP_SKU_BOARD_ID 0x13
#define ADL_RVP_BOARD_ID(id) ((id) & 0x3F)
diff --git a/baseboard/intelrvp/adlrvp_ioex_gpio.inc b/baseboard/intelrvp/adlrvp_ioex_gpio.inc
index ed200254d6..e5522b02b3 100644
--- a/baseboard/intelrvp/adlrvp_ioex_gpio.inc
+++ b/baseboard/intelrvp/adlrvp_ioex_gpio.inc
@@ -24,3 +24,8 @@ IOEX(USB_C3_BB_RETIMER_RST, EXPIN(IOEX_C3_PCA9675, 0, PCA9675_IO_P00), GPIO_OUT_
IOEX(USB_C3_BB_RETIMER_LS_EN, EXPIN(IOEX_C3_PCA9675, 0, PCA9675_IO_P01), GPIO_OUT_LOW)
IOEX(USB_C2_C3_OC, EXPIN(IOEX_C3_PCA9675, 0, PCA9675_IO_P10), GPIO_OUT_HIGH)
#endif
+
+/* ADL-RVP has custom GPIO implementation for reading board ID */
+UNIMPLEMENTED(BOARD_VERSION1)
+UNIMPLEMENTED(BOARD_VERSION2)
+UNIMPLEMENTED(BOARD_VERSION3)