diff options
| author | Nicolas Boichat <drinkcat@chromium.org> | 2017-12-28 08:14:02 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-01-03 22:43:03 -0800 |
| commit | f1631210397f2db38ed20aa21c44bc0f9d2bd97f (patch) | |
| tree | 0820819d0442dc7686efbb3206e93ce123989261 | |
| parent | eb781cc377fe8c5c2d1cb266b599c24e5e4e8cd5 (diff) | |
| download | chrome-ec-f1631210397f2db38ed20aa21c44bc0f9d2bd97f.tar.gz | |
poppy: Disable PULL_UP on BOARD_VERSION4
All shipping products will have board ID >= 8, so the board ID
strap 3 will never be left floating. In particular, board ID 8-15
will have an external pull-down on that pin, so leaving the
internal pull-up enabled is detrimental to power.
BUG=b:64503543
BRANCH=none
TEST=Boot poppy rev6.
Change-Id: I810b2a68ab8d35e9cea6fa18f1eeafa10e7039ea
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/845240
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
| -rw-r--r-- | board/poppy/gpio.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board/poppy/gpio.inc b/board/poppy/gpio.inc index 337e41ed78..c4562bb7bd 100644 --- a/board/poppy/gpio.inc +++ b/board/poppy/gpio.inc @@ -125,7 +125,7 @@ GPIO(LED_WHITE_C1, PIN(3, 0), GPIO_OUT_LOW) GPIO(BOARD_VERSION1, PIN(C, 4), GPIO_INPUT) /* Board ID bit0 */ GPIO(BOARD_VERSION2, PIN(C, 2), GPIO_INPUT) /* Board ID bit1 */ GPIO(BOARD_VERSION3, PIN(1, 3), GPIO_INPUT) /* Board ID bit2 */ -GPIO(BOARD_VERSION4, PIN(1, 7), GPIO_INPUT | GPIO_PULL_UP) /* Board ID strap 3 (ternary) */ +GPIO(BOARD_VERSION4, PIN(1, 7), GPIO_INPUT) /* Board ID strap 3 (ternary) */ /* Alternate functions GPIO definitions */ ALTERNATE(PIN_MASK(6, 0x30), 1, MODULE_UART, 0) /* GPIO64-65 */ /* UART from EC to Servo */ |