diff options
| author | Tommy Chung <tommy.chung@quanta.corp-partner.google.com> | 2021-08-20 10:45:44 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-22 16:58:36 +0000 |
| commit | 08e597f4352c709a094b901552fa79503be2bc64 (patch) | |
| tree | db39119c046a8aa1877fa1efc1b0cf1816451427 | |
| parent | dd46fdb485a9cdb82ae733e4cec2320931e78dbc (diff) | |
| download | chrome-ec-08e597f4352c709a094b901552fa79503be2bc64.tar.gz | |
Revert "TCPMv2: Fix LPM for non-dual role auto toggle chips"
This reverts commit 55f40b89d7f7b6cc3005e0d6fa755345d514a578.
Reason for revert: type-C port with IT83XX can not detect plugged in device since the dual role CC1/CC2 voltages keep at 3V other than toggling for device.
Original change's description:
> TCPMv2: Fix LPM for non-dual role auto toggle chips
>
> If the "dual role" is enabled and the TCPC chip does not support
> "Dual role auto toggle mode" then the PD state remains in
> PD_DRP_TOGGLE_ON state in active state of the AP. Hence check for CC
> line open state to decide to enter low power mode for such devices.
>
> BUG=b:195406641
> BRANCH=none
> TEST=Tested on ADL RVP, FUSB302 & IT83XX can enter LPM
> > pd 0 state
> Port C0 CC1, Disable - Role: SRC-UFP TC State: LowPowerMode,
> Flags: 0x0010 PE State: , Flags: 0x0001
>
> Change-Id: Ic70c6bfcd2ffd0721fdcaf6e61c68736971e037b
> Signed-off-by: Poornima Tom <poornima.tom@intel.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088161
> Tested-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
> Commit-Queue: Vijay Hiremath <vijay.p.hiremath@intel.com>
Bug: b:195406641
Change-Id: I9a2deed330b0169be220e9b0a83125eb6a6e0faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3109275
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 80ccb3124e..26fce67011 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -2306,12 +2306,7 @@ static void tc_unattached_snk_run(const int port) set_state_tc(port, TC_UNATTACHED_SRC); } else if (IS_ENABLED(CONFIG_USB_PD_TCPC_LOW_POWER) && (drp_state[port] == PD_DRP_FORCE_SINK || - drp_state[port] == PD_DRP_TOGGLE_OFF || - cc_is_open(cc1, cc2))) { - /* - * Enter low power mode for TCPCs that do not - * support DRP Autotoggle. - */ + drp_state[port] == PD_DRP_TOGGLE_OFF)) { set_state_tc(port, TC_LOW_POWER_MODE); } } @@ -2845,13 +2840,9 @@ static void tc_unattached_src_run(const int port) drp_state[port] == PD_DRP_TOGGLE_ON && tcpm_auto_toggle_supported(port) && cc_is_open(cc1, cc2)) set_state_tc(port, TC_DRP_AUTO_TOGGLE); - /* - * Enter low power mode for TCPCs that do not support DRP Autotoggle. - */ else if (IS_ENABLED(CONFIG_USB_PD_TCPC_LOW_POWER) && (drp_state[port] == PD_DRP_FORCE_SOURCE || - drp_state[port] == PD_DRP_TOGGLE_OFF || - cc_is_open(cc1, cc2))) + drp_state[port] == PD_DRP_TOGGLE_OFF)) set_state_tc(port, TC_LOW_POWER_MODE); } |