diff options
| author | Jeremy Bettis <jbettis@google.com> | 2021-08-23 16:35:48 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-24 19:34:48 +0000 |
| commit | 988e681ee37c6cf137db2d58f94a03ca73dcf014 (patch) | |
| tree | 1e65d991ada0d90d1b63802510273a954d6ced88 | |
| parent | c869b4d066e7ac6f53b81175f6c6c1414a129ea0 (diff) | |
| download | chrome-ec-988e681ee37c6cf137db2d58f94a03ca73dcf014.tar.gz | |
ec: Fix returning uninitialized vars
And just to make it clearer, don't return ret at the bottom of a
if all other cases already do if (ret) return ret;
As it turns out, building with coverage doesn't initialize vars to 0.
BUG=None
TEST=zmake coverage.
BRANCH=none
Change-Id: Iae5368673517724fd23cb01425c027db9a50644b
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3115428
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
| -rw-r--r-- | driver/als_tcs3400.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/driver/als_tcs3400.c b/driver/als_tcs3400.c index 0626e679ee..30b24c4412 100644 --- a/driver/als_tcs3400.c +++ b/driver/als_tcs3400.c @@ -258,7 +258,7 @@ tcs3400_adjust_sensor_for_saturation(struct motion_sensor_t *s, return ret; } - return ret; + return EC_SUCCESS; } /** @@ -537,7 +537,7 @@ void tcs3400_interrupt(enum gpio_signal signal) static int tcs3400_irq_handler(struct motion_sensor_t *s, uint32_t *event) { uint32_t status = 0; - int ret = EC_SUCCESS; + int ret; if (!(*event & CONFIG_ALS_TCS3400_INT_EVENT)) return EC_ERROR_NOT_HANDLED; @@ -565,7 +565,7 @@ static int tcs3400_irq_handler(struct motion_sensor_t *s, uint32_t *event) if (ret) return ret; - return ret; + return EC_SUCCESS; } static int tcs3400_rgb_get_scale(const struct motion_sensor_t *s, |