diff options
author | Caveh Jalali <caveh@chromium.org> | 2021-02-17 01:23:11 -0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-03-10 20:00:31 +0000 |
commit | aa1d507ab38889e934f4e99e814d7663588891bb (patch) | |
tree | d7350be1e78624e03ee6a27262d4b7e2637ebed2 | |
parent | 632d1e77e33f7f07f1e48585e03eb35525166210 (diff) | |
download | chrome-ec-aa1d507ab38889e934f4e99e814d7663588891bb.tar.gz |
Brya: Enable charger chip
This adds the charger chip support code.
BRANCH=none
BUG=b:173575131,b:180784200
TEST=with reset of CQ-Depend patches, brya boots to AP
Change-Id: I1b220376cb03197e13aad65f1e79692eaf8fb1e1
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2700316
Commit-Queue: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
-rw-r--r-- | baseboard/brya/baseboard.h | 20 | ||||
-rw-r--r-- | baseboard/brya/build.mk | 1 | ||||
-rw-r--r-- | baseboard/brya/charger.c | 88 | ||||
-rw-r--r-- | board/brya/board.c | 44 | ||||
-rw-r--r-- | board/brya/board.h | 7 | ||||
-rw-r--r-- | board/brya/ec.tasklist | 2 |
6 files changed, 162 insertions, 0 deletions
diff --git a/baseboard/brya/baseboard.h b/baseboard/brya/baseboard.h index 73e3b40868..fffec3b807 100644 --- a/baseboard/brya/baseboard.h +++ b/baseboard/brya/baseboard.h @@ -31,6 +31,26 @@ #define CONFIG_HOSTCMD_ESPI #define CONFIG_HOSTCMD_ESPI_VW_SLP_S4 +/* Common charger defines */ +#define CONFIG_CHARGE_MANAGER +#define CONFIG_CHARGER +#define CONFIG_CHARGER_DISCHARGE_ON_AC +#define CONFIG_CHARGER_INPUT_CURRENT 512 + +#define CONFIG_CMD_CHARGER_DUMP + +#define CONFIG_USB_CHARGER +#define CONFIG_BC12_DETECT_PI3USB9201 + +/* + * Don't allow the system to boot to S0 when the battery is low and unable to + * communicate on locked systems (which haven't PD negotiated) + */ +#define CONFIG_CHARGER_MIN_POWER_MW_FOR_POWER_ON_WITH_BATT 15000 +#define CONFIG_CHARGER_MIN_BAT_PCT_FOR_POWER_ON 3 +#define CONFIG_CHARGER_MIN_BAT_PCT_FOR_POWER_ON_WITH_AC 1 +#define CONFIG_CHARGER_MIN_POWER_MW_FOR_POWER_ON 15001 + /* Common battery defines */ #define CONFIG_BATTERY_SMART #define CONFIG_BATTERY_FUEL_GAUGE diff --git a/baseboard/brya/build.mk b/baseboard/brya/build.mk index e584ac342c..983fa50a0a 100644 --- a/baseboard/brya/build.mk +++ b/baseboard/brya/build.mk @@ -10,3 +10,4 @@ baseboard-y= baseboard-y+=battery_presence.o baseboard-y+=cbi_ec_fw_config.o baseboard-y+=cbi.o +baseboard-y+=charger.o diff --git a/baseboard/brya/charger.c b/baseboard/brya/charger.c new file mode 100644 index 0000000000..d55503ea81 --- /dev/null +++ b/baseboard/brya/charger.c @@ -0,0 +1,88 @@ +/* Copyright 2021 The Chromium OS Authors. All rights reserved. + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. + */ + +#include "common.h" + +#include "charger.h" +#include "charge_manager.h" +#include "driver/charger/bq25710.h" +#include "usbc_ppc.h" +#include "usb_pd.h" +#include "util.h" + +#include "charge_state_v2.h" + +#define CPRINTSUSB(format, args...) cprints(CC_USBCHARGE, format, ## args) +#define CPRINTFUSB(format, args...) cprintf(CC_USBCHARGE, format, ## args) + +/* Charger Chip Configuration */ +const struct charger_config_t chg_chips[] = { + { + .i2c_port = I2C_PORT_CHARGER, + .i2c_addr_flags = BQ25710_SMBUS_ADDR1_FLAGS, + .drv = &bq25710_drv, + }, +}; +BUILD_ASSERT(ARRAY_SIZE(chg_chips) == CHARGER_NUM); + +int board_set_active_charge_port(int port) +{ + int is_valid_port = board_is_usb_pd_port_present(port); + int i; + + if (port == CHARGE_PORT_NONE) { + CPRINTSUSB("Disabling all charger ports"); + + /* Disable all ports. */ + for (i = 0; i < ppc_cnt; i++) { + /* + * Do not return early if one fails otherwise we can + * get into a boot loop assertion failure. + */ + if (ppc_vbus_sink_enable(i, 0)) + CPRINTSUSB("Disabling C%d as sink failed.", i); + } + + return EC_SUCCESS; + } else if (!is_valid_port) { + return EC_ERROR_INVAL; + } + + /* Check if the port is sourcing VBUS. */ + if (ppc_is_sourcing_vbus(port)) { + CPRINTFUSB("Skip enable C%d", port); + return EC_ERROR_INVAL; + } + + CPRINTSUSB("New charge port: C%d", port); + + /* + * Turn off the other ports' sink path FETs, before enabling the + * requested charge port. + */ + for (i = 0; i < ppc_cnt; i++) { + if (i == port) + continue; + + if (ppc_vbus_sink_enable(i, 0)) + CPRINTSUSB("C%d: sink path disable failed.", i); + } + + /* Enable requested charge port. */ + if (ppc_vbus_sink_enable(port, 1)) { + CPRINTSUSB("C%d: sink path enable failed.", port); + return EC_ERROR_UNKNOWN; + } + + return EC_SUCCESS; +} + +__overridable void board_set_charge_limit(int port, int supplier, int charge_ma, + int max_ma, int charge_mv) +{ + charge_set_input_current_limit(MAX(charge_ma, + CONFIG_CHARGER_INPUT_CURRENT), + charge_mv); +} diff --git a/board/brya/board.c b/board/brya/board.c index 17242a73d6..9dc52a1046 100644 --- a/board/brya/board.c +++ b/board/brya/board.c @@ -6,6 +6,9 @@ #include "common.h" #include "cbi_ec_fw_config.h" +#include "charge_ramp.h" +#include "charger.h" +#include "console.h" #include "power_button.h" #include "power.h" #include "switch.h" @@ -13,6 +16,10 @@ #include "gpio_list.h" /* Must come after other header files. */ +/* Console output macros */ +#define CPRINTF(format, args...) cprintf(CC_CHARGER, format, ## args) +#define CPRINTS(format, args...) cprints(CC_CHARGER, format, ## args) + /******************************************************************************/ /* USB-A charging control */ @@ -35,3 +42,40 @@ __override void board_cbi_init(void) { config_usb_db_type(); } + +#ifdef CONFIG_CHARGE_RAMP_SW + +/* + * TODO(b/181508008): tune this threshold + */ + +#define BC12_MIN_VOLTAGE 4400 + +/** + * Return true if VBUS is too low + */ +int board_is_vbus_too_low(int port, enum chg_ramp_vbus_state ramp_state) +{ + int voltage; + + if (charger_get_vbus_voltage(port, &voltage)) + voltage = 0; + + CPRINTS("%s: charger reports VBUS %d on port %d", __func__, + voltage, port); + + if (voltage == 0) { + CPRINTS("%s: must be disconnected", __func__); + return 1; + } + + if (voltage < BC12_MIN_VOLTAGE) { + CPRINTS("%s: lower than %d", __func__, + BC12_MIN_VOLTAGE); + return 1; + } + + return 0; +} + +#endif /* CONFIG_CHARGE_RAMP_SW */ diff --git a/board/brya/board.h b/board/brya/board.h index 486e1ab2cc..ddbaddadb2 100644 --- a/board/brya/board.h +++ b/board/brya/board.h @@ -100,6 +100,13 @@ */ /* #define CONFIG_FANS FAN_CH_COUNT */ +/* Charger defines */ +#define CONFIG_CHARGER_BQ25720 +#define CONFIG_CHARGE_RAMP_SW +#define CONFIG_CHARGER_NARROW_VDC +#define CONFIG_CHARGER_SENSE_RESISTOR 10 +#define CONFIG_CHARGER_SENSE_RESISTOR_AC 10 + #ifndef __ASSEMBLER__ #include "gpio_signal.h" /* needed by registers.h */ diff --git a/board/brya/ec.tasklist b/board/brya/ec.tasklist index dda8729741..dd4f31ffed 100644 --- a/board/brya/ec.tasklist +++ b/board/brya/ec.tasklist @@ -12,9 +12,11 @@ #define CONFIG_TASK_LIST \ TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ + TASK_ALWAYS(CHG_RAMP, chg_ramp_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(USB_CHG_P0, usb_charger_task, 0, TASK_STACK_SIZE) \ TASK_ALWAYS(USB_CHG_P1, usb_charger_task, 0, TASK_STACK_SIZE) \ TASK_ALWAYS(USB_CHG_P2, usb_charger_task, 0, TASK_STACK_SIZE) \ + TASK_ALWAYS(CHARGER, charger_task, NULL, VENTI_TASK_STACK_SIZE) \ TASK_NOTEST(KEYPROTO, keyboard_protocol_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(HOSTCMD, host_command_task, NULL, LARGER_TASK_STACK_SIZE) \ |