diff options
| author | Aaron Massey <aaronmassey@google.com> | 2021-11-09 14:22:26 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-10 22:21:44 +0000 |
| commit | d5a91e86bb86b43898e9dc60560c424422b33a17 (patch) | |
| tree | b67448608a9791fd7a3f1ef3b5bc617788650e53 | |
| parent | 988d59dffb820820f35986432e744774dc1aaa37 (diff) | |
| download | chrome-ec-d5a91e86bb86b43898e9dc60560c424422b33a17.tar.gz | |
zephyr: sn5s330: emul fails unimplemented reg
Returning -EINVAL on I2C is inaccurate, do assertion fail instead.
BRANCH=none
BUG=b:203364783
TEST=zmake configure --test test-drivers
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Cq-Depend: chromium:3258523
Change-Id: I540fbc5dd9955bc0f622138215a234b409e057fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3271365
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
| -rw-r--r-- | zephyr/emul/emul_sn5s330.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/zephyr/emul/emul_sn5s330.c b/zephyr/emul/emul_sn5s330.c index 9fc3de7ea5..0f69007bd5 100644 --- a/zephyr/emul/emul_sn5s330.c +++ b/zephyr/emul/emul_sn5s330.c @@ -135,7 +135,8 @@ static int sn5s330_emul_read_byte(struct i2c_emul *emul, int reg, uint8_t *val, *val = data->func_set12_reg; break; default: - return -EINVAL; + __ASSERT(false, "Unimplemented Register Access Error on 0x%x", + reg); } return 0; @@ -197,7 +198,8 @@ static int sn5s330_emul_write_byte(struct i2c_emul *emul, int reg, uint8_t val, break; default: - return -EINVAL; + __ASSERT(false, "Unimplemented Register Access Error on 0x%x", + reg); } return 0; |