diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2021-10-25 17:55:15 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-09 18:31:39 +0000 |
| commit | f2c11d776e5d5d4aba69045cd1a5901185cc7295 (patch) | |
| tree | 813b50697f0774ad0754556797fa017ba2932d67 | |
| parent | ea1eee5cc83c63d7ff8d3aa36f777c54e7d40ac2 (diff) | |
| download | chrome-ec-f2c11d776e5d5d4aba69045cd1a5901185cc7295.tar.gz | |
power/rk3399: Change fake GPIO
When building with clang, it warns:
power/rk3399.c:605:26: error: implicit conversion from enumeration type
'enum power_signal' to different enumeration type 'enum gpio_signal'
[-Werror,-Wenum-conversion]
power_signal_interrupt(POWER_SIGNAL_COUNT);
~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
It appears the intent is to derive a signal to send that is beyond the
number of power signals, but "enum gpio_signal" and "enum power_signal"
are separate enums, so POWER_SIGNAL_COUNT could be some other valid
GPIO.
Note that this is a functional change.
BRANCH=none
BUG=b:172020503
TEST=CC=clang make BOARD=scarlet
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Iba143e8903c11a4315e6b74fdb8e3245938b2b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3243007
Reviewed-by: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | power/rk3399.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/power/rk3399.c b/power/rk3399.c index 9db25f0b28..a11a732689 100644 --- a/power/rk3399.c +++ b/power/rk3399.c @@ -602,7 +602,7 @@ static void power_signal_changed(void) * Pass a fake power gpio_signal to power_signal_interrupt(). * Note that here we make power_signal_interrupt() reentrant. */ - power_signal_interrupt(POWER_SIGNAL_COUNT); + power_signal_interrupt(GPIO_COUNT); in_signals = inew; } } |