diff options
| author | Tim Lin <tim2.lin@ite.corp-partner.google.com> | 2021-11-11 15:43:34 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-15 09:44:38 +0000 |
| commit | b89b4e6404f1620ee58555b89db115ff4a3d20f6 (patch) | |
| tree | 4d743d1975c9a16c0ad1ff2ee22ffbfa511369b0 | |
| parent | 727adfc0ef964f9acdd9793668ea19ba846443f3 (diff) | |
| download | chrome-ec-b89b4e6404f1620ee58555b89db115ff4a3d20f6.tar.gz | |
zephyr: build the board of hayato and krabby generates warning
Adding CL:3246296 patch to build will generate a warning as following.
It looks like a conflict between the named 'gpio' and the phandle of
pointing 'gpios'. This CL will fix it.
Warning (gpios_property): /power-signal-list/pmic_pwr_good:
Missing property '#gpio-cells' in node /named-gpios/pmic_ec_pwrgd or
bad phandle (referred from gpio[0])
Warning (gpios_property): /power-signal-list/ap_in_s3_l:
Missing property '#gpio-cells' in node /named-gpios/ap_in_sleep_l or
bad phandle (referred from gpio[0])
Warning (gpios_property): /power-signal-list/ap_wdt_asserted:
Missing property '#gpio-cells' in node /named-gpios/ap_ec_watchdog_l or
bad phandle (referred from gpio[0])
BRANCH=none
BUG=none
TEST= zmake testall
zmake -lDEBUG configure -b zephyr/projects/asurada/hayato/
zmake -lDEBUG configure -b zephyr/projects/corsola/krabby/
Change-Id: I4bfa523daba85e7cbe241f3dbb982544ff619bee
Signed-off-by: Tim Lin <tim2.lin@ite.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3275102
Reviewed-by: Keith Short <keithshort@chromium.org>
| -rw-r--r-- | zephyr/dts/bindings/cros_pwr_signal/power-signal-list.yaml | 2 | ||||
| -rw-r--r-- | zephyr/projects/asurada/hayato/gpio.dts | 6 | ||||
| -rw-r--r-- | zephyr/projects/corsola/krabby/gpio.dts | 6 | ||||
| -rw-r--r-- | zephyr/shim/include/power/power.h | 4 |
4 files changed, 9 insertions, 9 deletions
diff --git a/zephyr/dts/bindings/cros_pwr_signal/power-signal-list.yaml b/zephyr/dts/bindings/cros_pwr_signal/power-signal-list.yaml index 1346968cc0..89ad4f5d5e 100644 --- a/zephyr/dts/bindings/cros_pwr_signal/power-signal-list.yaml +++ b/zephyr/dts/bindings/cros_pwr_signal/power-signal-list.yaml @@ -12,7 +12,7 @@ properties: child-binding: description: Power Signal List child node properties: - gpio: + power-gpio-pin: description: PHandle to the associated GPIO type: phandle diff --git a/zephyr/projects/asurada/hayato/gpio.dts b/zephyr/projects/asurada/hayato/gpio.dts index 3c62140a8a..a7c01656e7 100644 --- a/zephyr/projects/asurada/hayato/gpio.dts +++ b/zephyr/projects/asurada/hayato/gpio.dts @@ -332,15 +332,15 @@ compatible = "mediatek,power-signal-list"; pmic_pwr_good { power-enum-name = "PMIC_PWR_GOOD"; - gpio = <&pmic_ec_pwrgd>; + power-gpio-pin = <&pmic_ec_pwrgd>; }; ap_in_s3_l { power-enum-name = "AP_IN_S3_L"; - gpio = <&ap_in_sleep_l>; + power-gpio-pin = <&ap_in_sleep_l>; }; ap_wdt_asserted { power-enum-name = "AP_WDT_ASSERTED"; - gpio = <&ap_ec_watchdog_l>; + power-gpio-pin = <&ap_ec_watchdog_l>; }; }; diff --git a/zephyr/projects/corsola/krabby/gpio.dts b/zephyr/projects/corsola/krabby/gpio.dts index 2bcc107e70..f02a7e5a14 100644 --- a/zephyr/projects/corsola/krabby/gpio.dts +++ b/zephyr/projects/corsola/krabby/gpio.dts @@ -290,15 +290,15 @@ compatible = "mediatek,power-signal-list"; pmic_pwr_good { power-enum-name = "PMIC_PWR_GOOD"; - gpio = <&pmic_ec_pwrgd>; + power-gpio-pin = <&pmic_ec_pwrgd>; }; ap_in_s3_l { power-enum-name = "AP_IN_S3_L"; - gpio = <&ap_in_sleep_l>; + power-gpio-pin = <&ap_in_sleep_l>; }; ap_wdt_asserted { power-enum-name = "AP_WDT_ASSERTED"; - gpio = <&ap_ec_watchdog_l>; + power-gpio-pin = <&ap_ec_watchdog_l>; }; }; diff --git a/zephyr/shim/include/power/power.h b/zephyr/shim/include/power/power.h index 26d6ddadea..d5e03f68fa 100644 --- a/zephyr/shim/include/power/power.h +++ b/zephyr/shim/include/power/power.h @@ -20,7 +20,7 @@ DT_STRING_UPPER_TOKEN( \ DT_PROP( \ cid, \ - gpio \ + power_gpio_pin \ ), \ enum_name \ ) @@ -29,7 +29,7 @@ DT_GPIO_FLAGS( \ DT_PROP( \ cid, \ - gpio \ + power_gpio_pin \ ), \ gpios \ ) & GPIO_ACTIVE_LOW \ |