diff options
author | Aseda Aboagye <aaboagye@google.com> | 2021-03-11 10:15:49 -0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-03-11 23:44:36 +0000 |
commit | 4a46e7af81d743ddd696a55fbbdbf9e6e890b97e (patch) | |
tree | b6f3c993a948013616e738b078e8acfda3136fc7 | |
parent | 0f7e8a8c28606538650e5767eff303d2f66f434d (diff) | |
download | chrome-ec-4a46e7af81d743ddd696a55fbbdbf9e6e890b97e.tar.gz |
dedede/raa489000: Set LPM exit debounce to 100ms
For some reason, when the RAA489000 TCPC exits low power mode, CC
status doesn't appear changed when using a servo v4. This causes us
to think no connection is present and immediately but the IC back into
low power mode. If we wait 100ms before querying the CC status reg,
it seems that then the right values are reported.
This commit adds a workaround by setting the LPM exit debounce time to
100ms.
BUG=b:182429150,b:181308089
BRANCH=dedede
TEST=Build and flash a board, verify that servo v4 with an external
charger is detected.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Ic0c2406fa20d0dad82adee865cd87c46d7126b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2752250
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
-rw-r--r-- | board/blipper/board.h | 2 | ||||
-rw-r--r-- | board/boten/board.h | 2 | ||||
-rw-r--r-- | board/galtic/board.h | 2 | ||||
-rw-r--r-- | board/magolor/board.h | 2 | ||||
-rw-r--r-- | board/metaknight/board.h | 2 | ||||
-rw-r--r-- | board/sasukette/board.h | 2 | ||||
-rw-r--r-- | board/storo/board.h | 2 | ||||
-rw-r--r-- | board/waddledoo/board.h | 2 |
8 files changed, 16 insertions, 0 deletions
diff --git a/board/blipper/board.h b/board/blipper/board.h index a051759f47..d3905df9ab 100644 --- a/board/blipper/board.h +++ b/board/blipper/board.h @@ -29,6 +29,8 @@ #define CONFIG_CHARGER_RAA489000 #define CONFIG_CHARGER_SENSE_RESISTOR_AC 10 #define CONFIG_CHARGER_SENSE_RESISTOR 10 +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* DAC for PSYS */ #define CONFIG_DAC diff --git a/board/boten/board.h b/board/boten/board.h index 5972b3ff52..ecd5908c5a 100644 --- a/board/boten/board.h +++ b/board/boten/board.h @@ -27,6 +27,8 @@ #define CONFIG_CHARGER_SENSE_RESISTOR_AC 10 #define CONFIG_CHARGER_SENSE_RESISTOR 10 #define CONFIG_OCPC_DEF_RBATT_MOHMS 22 /* R_DS(on) 11.6mOhm + 10mOhm sns rstr */ +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* DAC for PSYS */ #define CONFIG_DAC diff --git a/board/galtic/board.h b/board/galtic/board.h index 715b2f2f81..cd9cf8c176 100644 --- a/board/galtic/board.h +++ b/board/galtic/board.h @@ -31,6 +31,8 @@ #undef CONFIG_CHARGER_SINGLE_CHIP #define CONFIG_OCPC #define CONFIG_OCPC_DEF_RBATT_MOHMS 22 /* R_DS(on) 11.6mOhm + 10mOhm sns rstr */ +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) #define GPIO_USB_C1_INT_ODL GPIO_SUB_USB_C1_INT_ODL diff --git a/board/magolor/board.h b/board/magolor/board.h index f4b2641a8e..69880e491d 100644 --- a/board/magolor/board.h +++ b/board/magolor/board.h @@ -40,6 +40,8 @@ #define CONFIG_OCPC #undef CONFIG_CHARGER_SINGLE_CHIP #undef CONFIG_CMD_CHARGER_DUMP +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* GPIO for C1 interrupts, for baseboard use */ #define GPIO_USB_C1_INT_ODL GPIO_SUB_USB_C1_INT_ODL diff --git a/board/metaknight/board.h b/board/metaknight/board.h index 2c60781734..559bc5d97e 100644 --- a/board/metaknight/board.h +++ b/board/metaknight/board.h @@ -20,6 +20,8 @@ #define CONFIG_CHARGER_SENSE_RESISTOR_AC 10 #define CONFIG_CHARGER_SENSE_RESISTOR 10 #undef CONFIG_CHARGER_SINGLE_CHIP +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* * GPIO for C1 interrupts, for baseboard use diff --git a/board/sasukette/board.h b/board/sasukette/board.h index d5b2739f1f..3b1526c46d 100644 --- a/board/sasukette/board.h +++ b/board/sasukette/board.h @@ -34,6 +34,8 @@ #define CONFIG_CHARGER_SENSE_RESISTOR 10 #define CONFIG_CHARGER_SINGLE_CHIP #define CONFIG_CHARGER_PROFILE_OVERRIDE +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* LED */ #define CONFIG_LED_COMMON diff --git a/board/storo/board.h b/board/storo/board.h index 361f059060..6e2ccc6c8b 100644 --- a/board/storo/board.h +++ b/board/storo/board.h @@ -32,6 +32,8 @@ #define CONFIG_OCPC_DEF_RBATT_MOHMS 22 /* R_DS(on) 11.6mOhm + 10mOhm sns rstr */ #define CONFIG_OCPC #undef CONFIG_CHARGER_SINGLE_CHIP +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) #define GPIO_USB_C1_INT_ODL GPIO_SUB_USB_C1_INT_ODL diff --git a/board/waddledoo/board.h b/board/waddledoo/board.h index d2c013dffd..9a6465548a 100644 --- a/board/waddledoo/board.h +++ b/board/waddledoo/board.h @@ -35,6 +35,8 @@ #define CONFIG_OCPC_DEF_RBATT_MOHMS 22 /* R_DS(on) 11.6mOhm + 10mOhm sns rstr */ #define CONFIG_OCPC #undef CONFIG_CHARGER_SINGLE_CHIP +#undef CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE +#define CONFIG_USB_PD_TCPC_LPM_EXIT_DEBOUNCE (100 * MSEC) /* * GPIO for C1 interrupts, for baseboard use |