diff options
| author | Duncan Laurie <dlaurie@google.com> | 2017-01-22 17:07:33 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-01-23 02:03:27 -0800 |
| commit | 5307725091ccb54cb5e849fedbfc26388f13023f (patch) | |
| tree | 4de912758cf4737c21de4c54e1166f0bd7e00c04 | |
| parent | be47089750c5558cf158de46629e9de323ecb230 (diff) | |
| download | chrome-ec-5307725091ccb54cb5e849fedbfc26388f13023f.tar.gz | |
eve: Fix hibernate GPIO states
- Lid switch has an external pull-down so we should not
enable one here in hibernate
- LEDs should be high to turn off
BUG=chrome-os-partner:58666
BRANCH=none
TEST=manual testing:
1) power off and enter hibernate with alt+volup+h
2) ensure LEDs turn off
3) ensure system stays off when lid is closed
4) ensure system powers up when lid is opened
Change-Id: I3a13fa6e0fbcad4925f9fb1d96e6c38d7bb453c8
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://chromium-review.googlesource.com/431137
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | board/eve/board.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/board/eve/board.c b/board/eve/board.c index acce082513..9a6f713486 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -561,14 +561,14 @@ void board_hibernate_late(void) { int i; const uint32_t hibernate_pins[][2] = { - {GPIO_LID_OPEN, GPIO_INT_RISING | GPIO_PULL_DOWN}, + {GPIO_LID_OPEN, GPIO_INT_RISING}, /* Turn off LEDs in hibernate */ - {GPIO_CHARGE_LED_1, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_2, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_3, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_4, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_5, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_6, GPIO_OUTPUT | GPIO_LOW}, + {GPIO_CHARGE_LED_1, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_2, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_3, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_4, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_5, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_6, GPIO_OUTPUT | GPIO_HIGH}, /* * BD99956 handles charge input automatically. We'll disable * charge output in hibernate. Charger will assert ACOK_OD |