summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMary Ruthven <mruthven@chromium.org>2021-11-09 16:47:23 -0600
committerCommit Bot <commit-bot@chromium.org>2021-11-18 04:50:03 +0000
commit18262b77ea30bd5ea4f1c2e5c262904a6fe51677 (patch)
treed36577e8c2f470b7cffe6e275d2064a72026ba82
parent7b0bfa297669cb35667e318f1e6f59f7d4a87ee3 (diff)
downloadchrome-ec-18262b77ea30bd5ea4f1c2e5c262904a6fe51677.tar.gz
Revert "common: add BASE_CHANGE hook"
This reverts commit af908bfce225415c01d56b3f57cfc399d8485d3e. BUG=b:200823466 TEST=make buildall -j Change-Id: I36277d725500101097ad45a55173877688848797 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273413 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
-rw-r--r--common/hooks.c1
-rw-r--r--core/cortex-m/ec.lds.S4
-rw-r--r--core/host/host_exe.lds4
-rw-r--r--include/hooks.h7
-rw-r--r--include/link_defs.h2
5 files changed, 0 insertions, 18 deletions
diff --git a/common/hooks.c b/common/hooks.c
index 3e940624ed..a4768faffb 100644
--- a/common/hooks.c
+++ b/common/hooks.c
@@ -45,7 +45,6 @@ static const struct hook_ptrs hook_list[] = {
{__hooks_ac_change, __hooks_ac_change_end},
{__hooks_lid_change, __hooks_lid_change_end},
{__hooks_tablet_mode_change, __hooks_tablet_mode_change_end},
- {__hooks_base_attached_change, __hooks_base_attached_change_end},
{__hooks_pwrbtn_change, __hooks_pwrbtn_change_end},
{__hooks_battery_soc_change, __hooks_battery_soc_change_end},
#ifdef CONFIG_CASE_CLOSED_DEBUG_V1
diff --git a/core/cortex-m/ec.lds.S b/core/cortex-m/ec.lds.S
index 3f20cc6c5f..3a9c79ed61 100644
--- a/core/cortex-m/ec.lds.S
+++ b/core/cortex-m/ec.lds.S
@@ -226,10 +226,6 @@ SECTIONS
KEEP(*(.rodata.HOOK_TABLET_MODE_CHANGE))
__hooks_tablet_mode_change_end = .;
- __hooks_base_attached_change = .;
- KEEP(*(.rodata.HOOK_BASE_ATTACHED_CHANGE))
- __hooks_base_attached_change_end = .;
-
__hooks_pwrbtn_change = .;
KEEP(*(.rodata.HOOK_POWER_BUTTON_CHANGE))
__hooks_pwrbtn_change_end = .;
diff --git a/core/host/host_exe.lds b/core/host/host_exe.lds
index 45f3560014..86abf2ca06 100644
--- a/core/host/host_exe.lds
+++ b/core/host/host_exe.lds
@@ -77,10 +77,6 @@ SECTIONS {
KEEP(*(.rodata.HOOK_TABLET_MODE_CHANGE))
__hooks_tablet_mode_change_end = .;
- __hooks_base_attached_change = .;
- KEEP(*(.rodata.HOOK_BASE_ATTACHED_CHANGE))
- __hooks_base_attached_change_end = .;
-
__hooks_pwrbtn_change = .;
*(.rodata.HOOK_POWER_BUTTON_CHANGE)
__hooks_pwrbtn_change_end = .;
diff --git a/include/hooks.h b/include/hooks.h
index 34115b9420..6ac9b970d7 100644
--- a/include/hooks.h
+++ b/include/hooks.h
@@ -170,13 +170,6 @@ enum hook_type {
HOOK_TABLET_MODE_CHANGE,
/*
- * Detachable device connected to a base.
- *
- * Hook routines are called from the TICK task.
- */
- HOOK_BASE_ATTACHED_CHANGE,
-
- /*
* Power button pressed or released. Based on debounced power button
* state, not raw GPIO input.
*
diff --git a/include/link_defs.h b/include/link_defs.h
index 71749a6f39..c5647dd4dd 100644
--- a/include/link_defs.h
+++ b/include/link_defs.h
@@ -50,8 +50,6 @@ extern const struct hook_data __hooks_lid_change[];
extern const struct hook_data __hooks_lid_change_end[];
extern const struct hook_data __hooks_tablet_mode_change[];
extern const struct hook_data __hooks_tablet_mode_change_end[];
-extern const struct hook_data __hooks_base_attached_change[];
-extern const struct hook_data __hooks_base_attached_change_end[];
extern const struct hook_data __hooks_pwrbtn_change[];
extern const struct hook_data __hooks_pwrbtn_change_end[];
extern const struct hook_data __hooks_battery_soc_change[];