diff options
| author | Philip Chen <philipchen@google.com> | 2019-04-11 20:36:03 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-26 04:19:19 -0700 |
| commit | 8ba4eb33169847a0cd97b95048d29ae85c373944 (patch) | |
| tree | af707eff4248535dd547ab12937bbb50bd741833 | |
| parent | f730c0c1ab2cadb820676ef09ebb57888d48cb96 (diff) | |
| download | chrome-ec-8ba4eb33169847a0cd97b95048d29ae85c373944.tar.gz | |
hatch: Configure EC_INT pin as open-drain
Without this change, during POR, PP3300_A/PP1800_A rises and
then temporarily stays in a wrong voltage level before eventually
reaching 3.3V/1.8V.
BUG=b:129306003
BRANCH=None
TEST=see PP3300_A step correctly during POR
Change-Id: If5facf5b413d5936abe5a24785f408c7b112a2fa
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1564495
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
| -rw-r--r-- | board/hatch/board.c | 22 | ||||
| -rw-r--r-- | board/hatch/gpio.inc | 2 |
2 files changed, 1 insertions, 23 deletions
diff --git a/board/hatch/board.c b/board/hatch/board.c index bd126051ef..14f8855ab8 100644 --- a/board/hatch/board.c +++ b/board/hatch/board.c @@ -437,25 +437,3 @@ void board_overcurrent_event(int port, int is_overcurrented) /* Note that the level is inverted because the pin is active low. */ gpio_set_level(GPIO_USB_C_OC_ODL, !is_overcurrented); } - -/* Called on AP S5 -> S3 transition */ -static void board_chipset_startup(void) -{ - gpio_set_level(GPIO_EC_INT_L, 1); -} -DECLARE_HOOK(HOOK_CHIPSET_STARTUP, board_chipset_startup, - HOOK_PRIO_DEFAULT); - -/* Called on AP S3 -> S5 transition */ -static void board_chipset_shutdown(void) -{ - /* - * EC_INT_L is currently a push-pull pin and this causes leakage in G3 - * onto the PP3300_A_SOC rail. Pull this pin low when host enters S5 to - * avoid the leakage. It will be pulled back high when host transitions - * out of S5. - */ - gpio_set_level(GPIO_EC_INT_L, 0); -} -DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, - HOOK_PRIO_DEFAULT); diff --git a/board/hatch/gpio.inc b/board/hatch/gpio.inc index 9911e3d093..63ac5a2271 100644 --- a/board/hatch/gpio.inc +++ b/board/hatch/gpio.inc @@ -56,7 +56,7 @@ GPIO(EC_PCH_SYS_PWROK, PIN(3, 7), GPIO_OUT_LOW) GPIO(CPU_C10_GATE_L, PIN(6, 7), GPIO_INPUT) /* MKBP event synchronization */ -GPIO(EC_INT_L, PIN(7, 0), GPIO_OUT_HIGH) +GPIO(EC_INT_L, PIN(7, 0), GPIO_ODR_HIGH) /* USB and USBC Signals */ GPIO(USB_C_OC_ODL, PIN(B, 1), GPIO_ODR_HIGH) |